Bad design/naming in bt.runtime.BtRuntime.shutdownGracefully method

[atomashpolskiy]

This method is used for shutting down the lifecycle executor (of which there are currently two types: runtime startup and runtime shutdown), but uses configuration options that are supposed to control the maximum duration of individual shutdown hooks:

private void shutdownGracefully(ExecutorService executor) {
        executor.shutdown();
        try {
            long timeout = config.getShutdownHookTimeout().toMillis();
            boolean terminated = executor.awaitTermination(timeout, TimeUnit.MILLISECONDS);
            if (!terminated) {
                LOGGER.warn("Failed to shutdown executor in {} millis", timeout);
            }
        } catch (InterruptedException e) {
            // ignore
            LOGGER.warn("Interrupted while waiting for shutdown", e);
            executor.shutdownNow();
        }
    }

[atomashpolskiy]

Also need to move the enclosing try{} catch (InterruptedException e) {} block to the calling bt.runtime.BtRuntime.runHooks method to make sure that the exception is not accidentally swallowed with runHooks continuing to wait for something.

[yufeng-pan]

Hi atomashpolskiy, I am interested in this issue. Can I work on it?