Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overzealous observability change notifications #167

Open
heckj opened this issue May 7, 2024 · 0 comments
Open

Overzealous observability change notifications #167

heckj opened this issue May 7, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@heckj
Copy link
Collaborator

heckj commented May 7, 2024

Digging in with ludicrous tracing enabled, I found that in a number of places there are change notifications sent at ANY time that call is made that could change the document. In the case where the value that's set is identical, there shouldn't be a notification, as the document treats that as a no-op.

Baseline: the notifications should only be emitted when the set of changesets returned from heads() is actually different.

@heckj heckj added the enhancement New feature or request label May 7, 2024
@heckj heckj self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant