AVR-720 When both advantage and disadvantage exist on the same armor, stealth checks roll with advantage instead of cancelling

[damccull]

Describe the bug
When both advantage and disadvantage exist on the same armor, stealth checks roll with advantage instead of cancelling

Severity
Medium (minor functional impact)

Context
!check stealth

To Reproduce
Import DnDBeyond Artificer Armorer subclass with Scale Mail armor (medium armor)
Be level 3, and choose Infiltrator class Armor model
See both advantage and disadvantage on Stealth skill
Import character to avrae
!check stealth

Expected behavior
A normal roll without advantage or disadvantage

Screenshots

Additional context
Add any other context about the problem here.

[taine-bot]

Tracked as AVR-720.

[1drturtle]

Hi! Thanks for reporting a bug! If you could hop on the Avrae Dev discord server, we can try and help you out. In the future, it would be appreciated if you came to the server first so we can try to debug the issue before opening a bug report!

Link to the support server: https://support.avrae.io

[zhudotexe]

Hi there - please attach a link to the affected character to help reproduce this issue

[damccull]

Sure: https://ddb.ac/characters/36925910/Ig4riw

[zhudotexe]

The root cause of this is that the disadvantage from wearing armor has a restriction on it in the data, "with armor worn" - obviously this is true, but there's no way to programatically determine this, and Avrae ignores conditional adv/dis (otherwise e.g. Drow would have permanent dis on Perception). The advantage from Armor Model has no such condition, so only the advantage is considered.

[zhudotexe]

[damccull]

Ok, that's interesting. Looks like I can append 'dis' to the !check command to cancel it out manually. That can work as a workaround. Unsure if this should be fixed or not. You may close if not.

[Haravikk]

I was going to post about the lack of auto-disadvantage as an issue, but this one seems similar enough.

The correct "fix" to me would seem to be to impose disadvantage whenever armour that imposes it is worn, as I expect most players will assume their armour is worn at all times. The only issue is how easy it is to remove the armour; with a DDB linked account it's fairly easy to unequip it then !update to reflect the change, but is a command needed to make it possible to do it directly from Avrae?

I'm constantly having to remind players to roll with disadvantage because of their heavy armour, but it seems like auto-disadvantage should be common enough to be the default with those types of armour.

Only other issue I can think of would be whether Avrae can handle mithril armour?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.