Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React throws warning for unsafe componentWillReceiveProps #71

Open
sbeals opened this issue May 4, 2020 · 1 comment
Open

React throws warning for unsafe componentWillReceiveProps #71

sbeals opened this issue May 4, 2020 · 1 comment

Comments

@sbeals
Copy link

sbeals commented May 4, 2020

console.warn node_modules/react-dom/cjs/react-dom.development.js:88
Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
  • Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Line 158 of overdrive.js:


  componentWillReceiveProps () {
    this.onShowLock = false
    this.onHide()
  }      
@berzniz
Copy link
Owner

berzniz commented Jun 3, 2020

I will accept a PR that fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants