Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback Wanted] User permissions #58

Open
vinaykapadia opened this issue Apr 18, 2023 · 4 comments
Open

[Feedback Wanted] User permissions #58

vinaykapadia opened this issue Apr 18, 2023 · 4 comments

Comments

@vinaykapadia
Copy link

Not sure what to call it, but add an account type thats between User and Admin. Someone that can create rooms, start player, and edit the queue for the rooms they create, but can't create or edit users, or change the media folders.

Basically on the account page, out of Rooms, Users, Preferences, and My Account, User can access only My Account, Admin can access all, and this new account type can access My Account and Rooms.

This is useful because I can then have someone set up a room and run it without having to give them access to full admin features.

@bhj
Copy link
Owner

bhj commented Apr 19, 2023

Definitely want this! We've gotten a lot of mileage out of the isAdmin flag, but it's probably time to move to a system under the hood that would support arbitrary permissions and granularity (even if the UI on top stays simple).

Let's use this thread to hear wants/needs around user permissions. Thanks!

@bhj bhj changed the title Room Accounts [Feedback Wanted] User permissions Apr 19, 2023
@vinaykapadia
Copy link
Author

I wanted to start working on some concepts, but it took me, no joke, like 4 hours to get the code to even run on my machine (my node.js was all kinds of messed up and I'm not too familiar with it either). Finally got it running though. Will try some things tomorrow.

@vinaykapadia
Copy link
Author

I don't think we need more granularity than three account types, but maybe if we want it in the future we can prep now by setting up permissions and roles. But I also don't want to overdo it if it's not necessary.

@MercifulCamel
Copy link

Would also be nice if it was possible to set a default account type on newly created accounts.
It would help greatly if I could set the default account type to one that will be able to create rooms, start songs etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants