{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":1181927,"defaultBranch":"master","name":"bitcoin","ownerLogin":"bitcoin","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-12-19T15:16:43.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/528860?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1713369113.0","currentOid":""},"activityList":{"items":[{"before":"43003255c00f72a85188d29a313904f46513f1eb","after":"6f1d9064381d834b0f8daa9011f18ba40834d85a","ref":"refs/heads/master","pushedAt":"2024-05-09T03:12:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30063: build, test: Remove unused `TIMEOUT` environment variable\n\n189d0da3f6f561c808fdd9fbd4dfd34ccfa23fe1 build, test: Remove unused `TIMEOUT` environment variable (Hennadii Stepanov)\n\nPull request description:\n\n  Setting the `TIMEOUT` environment variable has been a noop in both cases since its introduction.\n\n  It seems to have been inadvertently copy-pasted from existed code. For example, in commit d80e3cbece857b293a4903ef49c4d543bb2cfb7f, it was needlessly copied from a valid case a few lines above for the `qa/pull-tester/run-bitcoind-for-test.sh` script.\n\nACKs for top commit:\n  maflcko:\n    utACK 189d0da3f6f561c808fdd9fbd4dfd34ccfa23fe1\n  edilmedeiros:\n    ACK 189d0da3f6f561c808fdd9fbd4dfd34ccfa23fe1\n\nTree-SHA512: 61111eba30e0c82a0220bea48eba451cd9caa68785b48ec8a91059ca5aadfaff2f6d2ccdc5aa737c5cefa33579cb735431bb9e94bda8fa047825d7bd28d542fb","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2285617240\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30063\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30063/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30063\">#30063</a>: build, test: Remove unused <code>TIMEOUT</code> environment variable"}},{"before":"8a45f572b9e0d4681a7e636df338d978841c27a3","after":"43003255c00f72a85188d29a313904f46513f1eb","ref":"refs/heads/master","pushedAt":"2024-05-08T22:40:03.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29292: rpc: improve submitpackage documentation and other improvements\n\n78e52f663f3e3ac86260b913dad777fd7218f210 doc: rpc: fix submitpackage examples (stickies-v)\n1a875d4049574730d4a53a1b68bd29b80ad96d38 rpc: update min package size error message in submitpackage (stickies-v)\nf9ece258aa868d0776caa86b94e71ba05a9b287e doc: rpc: submitpackage takes sorted array (stickies-v)\n17f74512f0d19cb452ed79a4bff5a222fcdb53c4 test: add bounds checking for submitpackage RPC (stickies-v)\n\nPull request description:\n\n  `submitpackage` requires the package to be topologically sorted with the child being the last element in the array, but this is not documented in the RPC method or the error messages.\n\n  Also sneaking in some other minor improvements that I found while going through the code:\n  - Informing the user that `package` needs to be an array of length between `1` and `MAX_PACKAGE_COUNT` is confusing when `IsChildWithPackage()` requires that the package size >= 2. Remove this check to avoid code duplication and sending a confusing error message.\n  - fixups to the `submitpackage` examples\n\nACKs for top commit:\n  fjahr:\n    re-ACK 78e52f663f3e3ac86260b913dad777fd7218f210\n  instagibbs:\n    ACK https://github.com/bitcoin/bitcoin/pull/29292/commits/78e52f663f3e3ac86260b913dad777fd7218f210\n  achow101:\n    ACK 78e52f663f3e3ac86260b913dad777fd7218f210\n  glozow:\n    utACK 78e52f663f3e3ac86260b913dad777fd7218f210\n\nTree-SHA512: a8845621bb1cbf784167fc7c82cb8ceb105868b65b26d3465f072d1c04ef3699e85a21a524ade805d423bcecbc34f7d5bff12f2c21cbd902ae1fb154193ebdc9","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2094704880\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29292\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29292/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29292\">#29292</a>: rpc: improve submitpackage documentation and other impr…"}},{"before":"573f6311658a7ef5b84a08c6aedeab35d2ac7956","after":"8a45f572b9e0d4681a7e636df338d978841c27a3","ref":"refs/heads/master","pushedAt":"2024-05-08T22:11:43.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29335: test: Handle functional test disk-full error\n\n357ad110548d726021547d85b5b2bfcf3191d7e3 test: Handle functional test disk-full error (Brandon Odiwuor)\n\nPull request description:\n\n  Fixes: https://github.com/bitcoin/bitcoin/issues/23099\n\n  Handle disk-full more gracefully in functional tests\n\nACKs for top commit:\n  itornaza:\n    re-ACK 357ad110548d726021547d85b5b2bfcf3191d7e3\n  achow101:\n    reACK 357ad110548d726021547d85b5b2bfcf3191d7e3\n  cbergqvist:\n    reACK 357ad110548d726021547d85b5b2bfcf3191d7e3. Looks good!\n  tdb3:\n    re ACK for 357ad110548d726021547d85b5b2bfcf3191d7e3\n\nTree-SHA512: 9bb0d3fbe84600c88873b9f55d4b5d1443f79ec303467680c301be2b4879201387f203d9d1984169461f321037189b5e10a6a4b9d61750de638f072d2f95d77e","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2104040175\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29335\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29335/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29335\">#29335</a>: test: Handle functional test disk-full error"}},{"before":"4ff42762fdbef983a886e5eb63cf21f7108fe78b","after":"573f6311658a7ef5b84a08c6aedeab35d2ac7956","ref":"refs/heads/master","pushedAt":"2024-05-08T22:04:37.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#26326: net: don't lock cs_main while reading blocks in net processing\n\n75d27fefc7a04ebdda7be5724a014b6a896e7325 net: reduce LOCK(cs_main) scope in ProcessGetBlockData (Andrew Toth)\n613a45cd4b5482aedbdc7c61c839ea05996935c6 net: reduce LOCK(cs_main) scope in GETBLOCKTXN (Andrew Toth)\n\nPull request description:\n\n  Inspired by https://github.com/bitcoin/bitcoin/pull/11913 and https://github.com/bitcoin/bitcoin/pull/26308.\n\n  `cs_main` doesn't need to be locked while reading blocks. This removes the locks in `net_processing`.\n\nACKs for top commit:\n  sr-gi:\n    ACK [75d27fe](https://github.com/bitcoin/bitcoin/pull/26326/commits/75d27fefc7a04ebdda7be5724a014b6a896e7325)\n  achow101:\n    ACK 75d27fefc7a04ebdda7be5724a014b6a896e7325\n  furszy:\n    ACK 75d27fefc with a non-blocking nit.\n  mzumsande:\n    Code Review ACK 75d27fefc7a04ebdda7be5724a014b6a896e7325\n  TheCharlatan:\n    ACK 75d27fefc7a04ebdda7be5724a014b6a896e7325\n\nTree-SHA512: 79b85f748f68ecfb2f2afd3267857dd41b8e76dd482c9c922037399dcbce7b1e5d4c708a4f5fd17c3fb6699b0d88f26a17cc1d92db115dd43c8d4392ae27cec4","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1411795876\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/26326\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/26326/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/26326\">#26326</a>: net: don't lock cs_main while reading blocks in net pro…"}},{"before":"43a66c55ec8770cf7c21112aac9b997f3f2fb704","after":"4ff42762fdbef983a886e5eb63cf21f7108fe78b","ref":"refs/heads/master","pushedAt":"2024-05-08T21:53:14.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28336: rpc: parse legacy pubkeys consistently with specific error messages\n\n98570fe29bb08d7edc48011aa6b9731c6ab4ed2e test: add coverage for parsing cryptographically invalid pubkeys (Sebastian Falbesoner)\nc740b154d193b91ca42f18759098d3fef6eaab05 rpc: use `HexToPubKey` helper for all legacy pubkey-parsing RPCs (Sebastian Falbesoner)\n100e8a75bf5d8196c005331bd8f2ed42ada6d8d0 rpc: check and throw specific pubkey parsing errors in `HexToPubKey` (Sebastian Falbesoner)\n\nPull request description:\n\n  Parsing legacy public keys can fail for three reasons (in this order):\n  - pubkey is not in hex\n  - pubkey has an invalid length (not 33 or 65 bytes for compressed/uncompressed, respectively)\n  - pubkey is crytographically invalid, i.e. is not on curve (`CPubKey.IsFullyValid()` check)\n\n  Many RPCs currently perform these checks manually with different error messages, even though we already have a `HexToPubKey` helper. This PR puts all three checks in this helper (the length check was done on the call-sites before), adds specific error messages for each case, and consequently uses it for all RPCs that parse legacy pubkeys. This leads to deduplicated code and also to more consistent and detailed error messages for the user.\n\n  Affected RPC calls are `createmultisig`, `addmultisigaddress`, `importpubkey`, `importmulti`, `fundrawtransaction`, `walletcreatefundedpsbt`, `send` and `sendall`.\n\n  Note that the error code (-5 a.k.a. `RPC_INVALID_ADDRESS_OR_KEY`) doesn't change in any of the causes, so the changes are not breaking RPC API compatibility. Only the messages are more specific.\n\n  The last commits adds test coverage for the cryptographically invalid (not-on-curve) pubkey case which wasn't exercised before.\n\nACKs for top commit:\n  stratospher:\n    tested ACK 98570fe.\n  davidgumberg:\n    ACK https://github.com/bitcoin/bitcoin/pull/28336/commits/98570fe29bb08d7edc48011aa6b9731c6ab4ed2e\n  Eunovo:\n    Tested ACK https://github.com/bitcoin/bitcoin/pull/28336/commits/98570fe29bb08d7edc48011aa6b9731c6ab4ed2e\n  achow101:\n    ACK 98570fe29bb08d7edc48011aa6b9731c6ab4ed2e\n\nTree-SHA512: cfa474176e95b5b18f3a9da28fdd9e87195cd58994c1331198f2840925fff322fd323a6371feab74a1b32e4b9ea58a6dc732fa751b4cdd45402c1029af609ece","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1865379780\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/28336\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/28336/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/28336\">#28336</a>: rpc: parse legacy pubkeys consistently with specific er…"}},{"before":"74f517b4411d80afa7733c088da961e9c736a97d","after":"43a66c55ec8770cf7c21112aac9b997f3f2fb704","ref":"refs/heads/master","pushedAt":"2024-05-08T08:15:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30053: test: added test coverage to loadtxoutset could not open file\n\nee67bba76cca2355541f99bb731f58479981b29e test: added test coverage to loadtxoutset (kevkevin)\n\nPull request description:\n\n  The functional test coverage did not cover the rpc error of \"Couldn't open file...\" for loadtxoutset and this test adds coverage for it\n\n  This adds coverage to this line\n  https://github.com/bitcoin/bitcoin/blob/master/src/rpc/blockchain.cpp#L2777\n\nACKs for top commit:\n  maflcko:\n    ACK ee67bba76cca2355541f99bb731f58479981b29e\n  davidgumberg:\n    LGTM ACK https://github.com/bitcoin/bitcoin/pull/30053/commits/ee67bba76cca2355541f99bb731f58479981b29e\n  rkrux:\n    ACK [ee67bba](https://github.com/bitcoin/bitcoin/pull/30053/commits/ee67bba76cca2355541f99bb731f58479981b29e)\n  alfonsoromanz:\n    ACK ee67bba76cca2355541f99bb731f58479981b29e. Code looks good to me. I also ran `test/functional/feature_assumeutxo.py` to make sure all tests passes, including this one.\n  tdb3:\n    ACK for ee67bba76cca2355541f99bb731f58479981b29e\n\nTree-SHA512: 210a7eb928f625d2a8d9acb63ee83cb4aaec9c267e5a0c52ad219c2935466e2cdc68667e30ad29566e6060981587e5bec42805d296f6e60f9b3b13f3330575f2","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2281816402\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30053\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30053/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30053\">#30053</a>: test: added test coverage to loadtxoutset could not ope…"}},{"before":"09d3ad2861a0127d2cdcf81a8d82f6da6b0f16c1","after":"74f517b4411d80afa7733c088da961e9c736a97d","ref":"refs/heads/master","pushedAt":"2024-05-08T03:56:39.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30054: ci: Exclude feature_init for now in valgrind task\n\nfab179d10243e85cdb172a9f08bcb7ec19ddf74d ci: Exclude feature_init for now in valgrind task (MarcoFalke)\n\nPull request description:\n\n  Fixes https://github.com/bitcoin/bitcoin/issues/30011\n\nACKs for top commit:\n  fanquake:\n    ACK fab179d10243e85cdb172a9f08bcb7ec19ddf74d\n\nTree-SHA512: 5943a2abcec59253af8775e8ac7a120011a92cb66711b01a7e377a9302175d56c7de39ce028edc875b1584bf65458f92face2b0ee2028e84f4d3978d2cbafd0a","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2282427202\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30054\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30054/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30054\">#30054</a>: ci: Exclude feature_init for now in valgrind task"}},{"before":"4e56df8f915bf6e769920ef12e7c52848786a56d","after":"09d3ad2861a0127d2cdcf81a8d82f6da6b0f16c1","ref":"refs/heads/master","pushedAt":"2024-05-08T03:54:54.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30025: doc: fix broken relative md links\n\n4b9f49da2b120e81516ddc3dc577d7a2e58e02d3 doc: fix broken relative md links (willcl-ark)\n\nPull request description:\n\n  These relative links in our documentation are broken, fix them.\n\nACKs for top commit:\n  maflcko:\n    ACK 4b9f49da2b120e81516ddc3dc577d7a2e58e02d3\n  ryanofsky:\n    Code review ACK 4b9f49da2b120e81516ddc3dc577d7a2e58e02d3. Thanks for the updates!\n  ismaelsadeeq:\n    Re ACK 4b9f49da2b120e81516ddc3dc577d7a2e58e02d3\n\nTree-SHA512: df4ef5ddece6c21125ce719ed6a4f69aba4f884c353ff7a8445ecb6438ed6bf0ff8268a1ae19cdd910adaadc189c6861c445b4d469f92ee81874d810dcbd0846","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2276430128\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30025\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30025/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30025\">#30025</a>: doc: fix broken relative md links"}},{"before":"8efd03ad04726aa34219ad83115a3d45030412c3","after":"4e56df8f915bf6e769920ef12e7c52848786a56d","ref":"refs/heads/master","pushedAt":"2024-05-07T20:34:42.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin-core/gui#819: Fix misleading signmessage error with segwit\n\nfb9f150759b22772dd48983a2be1ea397245e289 gui: fix misleading signmessage error with segwit (willcl-ark)\n\nPull request description:\n\n  As described in https://github.com/bitcoin/bitcoin/issues/10542 (and numerous other places), message signing in Bitcoin Core does not support \"signing with a segwit address\" and likely will not in the foreseeable future, or at least until a new message-signing standard is agreed upon.\n\n  Therefore update the possibly misleading error message presented to the user in the GUI to detail more specifically the reason their message cannot be signed, in the case that a non P2PKH address is entered.\n\n  This change takes the [suggested wording](https://github.com/bitcoin/bitcoin/issues/10542#issuecomment-1960313569) from @adiabat.\n\n  Perhaps with this we can close https://github.com/bitcoin/bitcoin/issues/10542 ?\n\nACKs for top commit:\n  hebasto:\n    ACK fb9f150759b22772dd48983a2be1ea397245e289.\n\nTree-SHA512: 5ba8d722ad3632dad2e0a2aa94b0f466b904e7885a247a5d26ebdfce54e3611090b103029d8dfce92adc49e50fe5f4830f687d867b4c56c3ea997e519b4e188d","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2268988663\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin-core/gui/issues/819\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin-core/gui/pull/819/hovercard\" href=\"https://github.com/bitcoin-core/gui/pull/819\">bitcoin-core/gui#819</a>: Fix misleading signmessage error with segwit"}},{"before":"ef09f535b7b540d997f8c2bfa67b3386711bc8b4","after":"8efd03ad04726aa34219ad83115a3d45030412c3","ref":"refs/heads/master","pushedAt":"2024-05-07T18:14:17.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29494: build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bitcoin-config.h includes\n\nfa09451f8e6799682d7e7c863f25334fd1c7dce3 Add lint check for bitcoin-config.h include IWYU pragma (MarcoFalke)\ndddd40ba8267dea11a3eb03d5cf8b51dbb99be5d scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes (MarcoFalke)\n\nPull request description:\n\n  The `bitcoin-config.h` includes have issues:\n\n  * The header is incompatible with iwyu, because symbols may be defined or not defined. So the `IWYU pragma: keep` is needed to keep the include when a symbol is not defined on a platform. Compare the previous discussion in https://github.com/bitcoin/bitcoin/pull/29408#issuecomment-1948959711\n  * Guarding the includes by `HAVE_CONFIG_H` is verbose and brittle. Now that all build config dependencies have been removed from low level headers, the benefits are questionable, and the guard can be removed. The linter could also be tricked by guarding the include by `#if defined(HAVE_C0NFIG_H)` (`O` replaced by `0`). Compare the previous discussion in https://github.com/bitcoin/bitcoin/pull/29404#discussion_r1483189853 .\n\nACKs for top commit:\n  achow101:\n    ACK fa09451f8e6799682d7e7c863f25334fd1c7dce3\n  TheCharlatan:\n    ACK fa09451f8e6799682d7e7c863f25334fd1c7dce3\n  hebasto:\n    re-ACK fa09451f8e6799682d7e7c863f25334fd1c7dce3, only rebased since my recent [review](https://github.com/bitcoin/bitcoin/pull/29494#pullrequestreview-2028864535) (`timedata.cpp` removed in https://github.com/bitcoin/bitcoin/pull/29623).\n\nTree-SHA512: 47cb973f7f24bc625acc4e78683371863675d186780236d55d886cf4130e05a78bb04f1d731aae7088313b8e963a9677cc77cf518187dbd99d776f6421ca9b52","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2157358912\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29494\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29494/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29494\">#29494</a>: build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bi…"}},{"before":"63d0b930f821132badd804822a46232a5f98bbef","after":"ef09f535b7b540d997f8c2bfa67b3386711bc8b4","ref":"refs/heads/master","pushedAt":"2024-05-07T02:29:06.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29984: net: Replace ifname check with IFF_LOOPBACK in Discover\n\na68fed111be393ddbbcd7451f78bc63601253ee0 net: Fix misleading comment for Discover (laanwj)\n7766dd280d9a4a7ffdfcec58224d0985cfd4169b net: Replace ifname check with IFF_LOOPBACK in Discover (laanwj)\n\nPull request description:\n\n  Checking the interface name is kind of brittle. In the age of network namespaces and containers, there is no reason a loopback interface can't be called differently.\n\n  Check for the `IFF_LOOPBACK` flag to detect loopback interface instead.\n\n  Also remove a misleading comment in Discover's doc comment.\n\nACKs for top commit:\n  sipa:\n    utACK a68fed111be393ddbbcd7451f78bc63601253ee0\n  willcl-ark:\n    utACK a68fed111be393ddbbcd7451f78bc63601253ee0\n  theuni:\n    utACK a68fed111be393ddbbcd7451f78bc63601253ee0. Satoshi-era brittleness :)\n\nTree-SHA512: e2d7fc541f40f6a6af08286e7bcb0873ff55debdcd8b38b03f274897b673a6fb51d84d6c7241a02a9567ddf2645f50231d91bb1f55307ba7c6e68196c29b0edf","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2267457457\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29984\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29984/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29984\">#29984</a>: net: Replace ifname check with IFF_LOOPBACK in Discover"}},{"before":"fdb41e08c4a4fb2743f8ca7c4b8dac52a460e864","after":"63d0b930f821132badd804822a46232a5f98bbef","ref":"refs/heads/master","pushedAt":"2024-05-06T16:24:20.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29845: rpc: return warnings as an array instead of just a single one\n\n42fb5311b19582361409d65c6fddeadbee14bb97 rpc: return warnings as an array instead of just a single one (stickies-v)\n\nPull request description:\n\n  The RPC documentation for `getblockchaininfo`, `getmininginfo` and `getnetworkinfo` states that \"warnings\" returns \"any network and blockchain warnings\". In practice, only a single warning (i.e. the latest one that is set) is returned, the other ones are ignored.\n\n  Fix that by returning all warnings as an array.\n\n  As a side benefit, clean up the GetWarnings() logic.\n\n  Since this PR changes the RPC result schema, I've added release notes. Users can temporarily revert to the old results by using `-deprecatedrpc=warnings`, until it's removed in a future version.\n\n  ---\n\n  Some historical context from git log:\n\n  - when `GetWarnings` was introduced in 401926283a200994ecd7df8eae8ced8e0b067c46, it was used in the `getinfo` RPC, where only a [single error/warning was returned](https://github.com/bitcoin/bitcoin/commit/401926283a200994ecd7df8eae8ced8e0b067c46#diff-7442c48d42cd5455a79915a0f00cce5e13359db46437a32b812876edb0a5ccddR250) (similar to how it is now).\n  - later on, \"warnings\" RPC response fields were introduced, e.g. in ef2a3de25c882396e1776b554878d2784b6b7391, with the description [stating](https://github.com/bitcoin/bitcoin/commit/ef2a3de25c882396e1776b554878d2784b6b7391#diff-1021bd3c74415ad9719bd764ad6ca35af5dfb33b1cd863c0be49bdf52518af54R411) that it returned \"any network warnings\" but in practice still only a single warning was returned\n\nACKs for top commit:\n  achow101:\n    re-ACK 42fb5311b19582361409d65c6fddeadbee14bb97\n  tdb3:\n    Re ACK for 42fb5311b19582361409d65c6fddeadbee14bb97\n  TheCharlatan:\n    ACK 42fb5311b19582361409d65c6fddeadbee14bb97\n  maflcko:\n    ACK 42fb5311b19582361409d65c6fddeadbee14bb97 🔺\n\nTree-SHA512: 4225ed8979cd5f030dec785a80e7452a041ad5703445da79d2906ada983ed0bbe7b15889d663d75aae4a77d92e302c93e93eca185c7bd47c9cce29e12f752bd3","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2235262089\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29845\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29845/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29845\">#29845</a>: rpc: return warnings as an array instead of just a sing…"}},{"before":"00ac1b963d08f2779d2197edcdb1e76392993378","after":"fdb41e08c4a4fb2743f8ca7c4b8dac52a460e864","ref":"refs/heads/master","pushedAt":"2024-05-06T13:02:40.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29773: build, bench, msvc: Add missing benchmarks\n\n31a15f0aff79d2b34a9640909b9e6fb39a647b60 bench: Disable WalletCreate* benchmarks when building with MSVC (Hennadii Stepanov)\n23dc0c19acd54cad1bed2f14df024b6b533f2330 msvc, bench: Add missing source files to bench_bitcoin project (Hennadii Stepanov)\n\nPull request description:\n\n  On the master branch, the `bench_bitcoin.vcxproj` MSVC project misses wallet-specific source files.\n\n  This PR fixes this issue.\n\n  Benchmark run on Windows:\n  ```\n  > src\\bench_bitcoin.exe -filter=\"CoinSelection|BnBExhaustion|Wallet.*\"\n\n  |               ns/op |                op/s |    err% |     total | benchmark\n  |--------------------:|--------------------:|--------:|----------:|:----------\n  |          398,800.00 |            2,507.52 |    1.5% |      0.01 | `BnBExhaustion`\n  |          584,450.00 |            1,711.01 |    1.5% |      0.01 | `CoinSelection`\n  |       86,603,650.00 |               11.55 |    0.4% |      1.91 | `WalletAvailableCoins`\n  |            7,604.00 |          131,509.73 |    0.9% |      0.01 | `WalletBalanceClean`\n  |          124,028.57 |            8,062.66 |    2.6% |      0.01 | `WalletBalanceDirty`\n  |            7,587.12 |          131,802.30 |    1.9% |      0.01 | `WalletBalanceMine`\n  |               48.58 |       20,583,872.99 |    0.9% |      0.01 | `WalletBalanceWatch`\n  |        2,371,060.00 |              421.75 |    1.3% |      0.13 | `WalletCreateTxUseOnlyPresetInputs`\n  |       96,861,760.00 |               10.32 |    0.9% |      5.31 | `WalletCreateTxUsePresetInputsAndCoinSelection`\n  |              280.71 |        3,562,424.13 |    1.5% |      0.01 | `WalletIsMineDescriptors`\n  |            1,033.47 |          967,618.32 |    0.3% |      0.01 | `WalletIsMineLegacy`\n  |              282.36 |        3,541,599.91 |    0.5% |      0.01 | `WalletIsMineMigratedDescriptors`\n  |      484,547,300.00 |                2.06 |    1.0% |      2.43 | `WalletLoadingDescriptors`\n  |       29,924,300.00 |               33.42 |    0.4% |      0.15 | `WalletLoadingLegacy`\n  ```\n\nACKs for top commit:\n  maflcko:\n    lgtm ACK 31a15f0aff79d2b34a9640909b9e6fb39a647b60\n\nTree-SHA512: 0241af06126edf612489322cdce66ba43792066b5400b1719a8b9d1ec62030e8a9d497e2f01e38290e94c387db59ccf2a458f4b35d3dc8030a1a1413d89eb792","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2216872952\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29773\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29773/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29773\">#29773</a>: build, bench, msvc: Add missing benchmarks"}},{"before":"f7b81c7e1edb1d2d972b8d1e81e40f381d9beb59","after":"00ac1b963d08f2779d2197edcdb1e76392993378","ref":"refs/heads/master","pushedAt":"2024-05-06T01:47:42.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29960: depends: pass verbose through to cmake based makefiles\n\n7c69baf227252511455bc06e315f6a3c7fc5a398 depends: pass verbose through to cmake based make (Max Edwards)\n\nPull request description:\n\n  While testing https://github.com/bitcoin/bitcoin/pull/29708 I was not able to enable verbose output to check which flags were being given to the compiler.\n\n  With this PR, running depends with V=1 will enable verbose output from makefiles generated by cmake.\n\n  How to test:\n\n  ```shell\n  make -C depends libnatpmp V=1\n  ```\n\nACKs for top commit:\n  hebasto:\n    ACK 7c69baf227252511455bc06e315f6a3c7fc5a398. Tested using the folowing command:\n  fanquake:\n    ACK 7c69baf227252511455bc06e315f6a3c7fc5a398\n\nTree-SHA512: 81cd1326e940c5f14cbde96735fd02b03c1150881ed88d1e8dfa9385dfa12284bfa2cdfe097ce5f43a726c1718afb76ae16f71552ab68c207d74fdc1f7bb46ae","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2263551160\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29960\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29960/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29960\">#29960</a>: depends: pass verbose through to cmake based makefiles"}},{"before":"eb0bdbdd753bca97120247b921fd29d606fea6e9","after":"f7b81c7e1edb1d2d972b8d1e81e40f381d9beb59","ref":"refs/heads/master","pushedAt":"2024-05-06T01:34:02.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30031: msvc: Compile `test\\fuzz\\miniscript.cpp`\n\n9155b733e153e799f09cc7f7e9199ad776b2cbb1 build, msvc: Compile test\\fuzz\\miniscript.cpp (Hennadii Stepanov)\n\nPull request description:\n\n  This PR resolves the remained point from the https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2028808614:\n  > What is the issue with the ... miniscript fuzz tests?\n\n  From the CI [log](https://github.com/bitcoin/bitcoin/actions/runs/8941546183/job/24562123707?pr=30031#step:29:234):\n  ```\n  miniscript_script: succeeded against 721 files in 1s.\n  Run miniscript_script with args ['D:\\\\a\\\\bitcoin\\\\bitcoin\\\\src\\\\fuzz.exe', WindowsPath('D:/a/_temp/qa-assets/fuzz_seed_corpus/miniscript_script')]\n  miniscript_smart: succeeded against 1429 files in 2s.\n  Run miniscript_smart with args ['D:\\\\a\\\\bitcoin\\\\bitcoin\\\\src\\\\fuzz.exe', WindowsPath('D:/a/_temp/qa-assets/fuzz_seed_corpus/miniscript_smart')]\n  miniscript_stable: succeeded against 1871 files in 2s.\n  Run miniscript_stable with args ['D:\\\\a\\\\bitcoin\\\\bitcoin\\\\src\\\\fuzz.exe', WindowsPath('D:/a/_temp/qa-assets/fuzz_seed_corpus/miniscript_stable')]\n  miniscript_string: succeeded against 918 files in 3s.\n  Run miniscript_string with args ['D:\\\\a\\\\bitcoin\\\\bitcoin\\\\src\\\\fuzz.exe', WindowsPath('D:/a/_temp/qa-assets/fuzz_seed_corpus/miniscript_string')]\n  ```\n\nACKs for top commit:\n  maflcko:\n    ACK 9155b733e153e799f09cc7f7e9199ad776b2cbb1\n  TheCharlatan:\n    ACK 9155b733e153e799f09cc7f7e9199ad776b2cbb1\n\nTree-SHA512: 967f199aac41733265532518ff7b1d881ba5a7bbde9f827d6a0b6d984c94a65b20d5854ce0ea247158eaa17b21d4c9f7d25c79bac17960788bacd2586112630b","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2277561778\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30031\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30031/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30031\">#30031</a>: msvc: Compile <code>test\\fuzz\\miniscript.cpp</code>"}},{"before":"61d3280c3a36084a6fef17fcedb3de3555294424","after":"eb0bdbdd753bca97120247b921fd29d606fea6e9","ref":"refs/heads/master","pushedAt":"2024-05-04T01:13:21.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28657: miniscript: make operator\"\"_mst consteval\n\n63317103c9f2b0635558da814567bb79c17ae851 miniscript: make operator_mst consteval (Pieter Wuille)\n\nPull request description:\n\n  It seems modern compilers don't realize that all invocations of operator\"\"_mst can be evaluated at compile time, despite the `constexpr` keyword.\n\n  Since C++20, we can force them to evaluate at compile time using `consteval`, turning all the miniscript type constants into actual compile-time constants.\n\n  This should give a nice but not very important speedup for miniscript logic, but it's also a way to start testing C++20 features.\n\nACKs for top commit:\n  hebasto:\n    re-ACK 63317103c9f2b0635558da814567bb79c17ae851.\n  theuni:\n    utACK 63317103c9f2b0635558da814567bb79c17ae851\n\nTree-SHA512: bdc9f1a6499b8bb3ca04f1a158c31e6876ba97206f95ee5718f50efd58b5b4e6b8867c07f791848430bfaa130b9676d8a68320b763cda9a340c75527acbfcc9e","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1945330923\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/28657\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/28657/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/28657\">#28657</a>: miniscript: make operator\"\"_mst consteval"}},{"before":"bd597c33e3e58cd3c6b22ed42f8f1fd7ff886bb2","after":"61d3280c3a36084a6fef17fcedb3de3555294424","ref":"refs/heads/master","pushedAt":"2024-05-04T01:07:50.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29907: test: Fix `test/streams_tests.cpp` compilation on SunOS / illumos\n\n976e5d8f7b2bc77cb1443b8bf0f38cb07db70e9b test: Fix `test/streams_tests.cpp` compilation on SunOS / illumos (Hennadii Stepanov)\n\nPull request description:\n\n  On systems where `int8_t` is defined as `char`, the `{S,Uns}erialize(Stream&, signed char)` functions become undefined.\n\n  This PR resolves the issue by testing `{S,Uns}erialize(Stream&, int8_t)` instead.\n\n  No behavior change on systems where `int8_t` is defined as `signed char`, which is the case for most other systems.\n\n  Fixes https://github.com/bitcoin/bitcoin/issues/29884.\n\n  An alternative approach is mentioned in https://github.com/bitcoin/bitcoin/issues/29884#issuecomment-2058434577 as well.\n\nACKs for top commit:\n  maflcko:\n    lgtm ACK 976e5d8f7b2bc77cb1443b8bf0f38cb07db70e9b\n  theuni:\n    ACK 976e5d8f7b2bc77cb1443b8bf0f38cb07db70e9b. Nice to have the serialization concept actually tested :)\n\nTree-SHA512: 1033863e584fa8e99a281b236fa01fc919f610a024bcec792116762e28c1c16ee481bd01325c3a0ca9dd9d753176aa63bd9ac7e08a9bbce772db2949d06f6e61","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2251505816\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29907\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29907/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29907\">#29907</a>: test: Fix <code>test/streams_tests.cpp</code> compilation on SunOS…"}},{"before":"f5b6f621fff7540ca97974b26a66ca1cc6db018c","after":"bd597c33e3e58cd3c6b22ed42f8f1fd7ff886bb2","ref":"refs/heads/master","pushedAt":"2024-05-04T00:47:31.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#25972: build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set\n\nf0e22be69a15248c42964d57f44ce8c37a36081d build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set (fanquake)\nb088062e687d95deff28b0715fd4859449b56584 ci: remove -Wdocumentation from -Werror in multiprocess CI (fanquake)\nbec6a88fbcff0bd974e820cefd2be2d00b6f6c56 ci: remove -Warray-bounds from -Werror for win64 (fanquake)\n7469ac7032e26fe805c5d15ecded2d44253bc9c1 ci: disable -Werror=maybe-uninitialized for Windows builds (fanquake)\n\nPull request description:\n\n  Now that `CXXFLAGS` are [back in user control](https://github.com/bitcoin/bitcoin/pull/24391), I don't think there's a\n  reason to no-longer use our warning flags when `CXXFLAGS` has been\n  overriden (this includes, by default, when building from depends).\n\n  Anyone can suppress warnings from third-party code by\n  passing the relevant `-Wno-` options in `CXXFLAGS`.\n\n  Closes: #18092.\n\nACKs for top commit:\n  maflcko:\n    utACK f0e22be69a15248c42964d57f44ce8c37a36081d 🍡\n  hebasto:\n    ACK f0e22be69a15248c42964d57f44ce8c37a36081d.\n  theuni:\n    ACK f0e22be69a15248c42964d57f44ce8c37a36081d. It'll be nice to have this fixed.\n  TheCharlatan:\n    ACK f0e22be69a15248c42964d57f44ce8c37a36081d\n\nTree-SHA512: dcef4bd4a57bab6f586ca015fad725e7a38bf24b7a08808a74d8c8ca47cf68c5fca7b04ed38649a047c6929fb708e2c97f2000fc46d5a8d25da49951c5bb0f66","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1358933376\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/25972\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/25972/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/25972\">#25972</a>: build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is…"}},{"before":"f9486de6a96b624982a2d45b895bfe4e865063d1","after":"f5b6f621fff7540ca97974b26a66ca1cc6db018c","ref":"refs/heads/master","pushedAt":"2024-05-03T16:37:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30024: doc: replace remaining \"520\" magic nums with MAX_SCRIPT_ELEMENT_SIZE\n\nffc674595cb19b2fdc5705b355bdd3e7f724b860 Replace remaining \"520\" magic numbers with MAX_SCRIPT_ELEMENT_SIZE (Jon Atack)\n\nPull request description:\n\n  Noticed these while reviewing BIPs yesterday.\n\n  It would be clearer and more future-proof to refer to their constant name.\n\nACKs for top commit:\n  instagibbs:\n    ACK ffc674595cb19b2fdc5705b355bdd3e7f724b860\n  sipa:\n    ACK ffc674595cb19b2fdc5705b355bdd3e7f724b860\n  achow101:\n    ACK ffc674595cb19b2fdc5705b355bdd3e7f724b860\n  glozow:\n    ACK ffc674595cb19b2fdc5705b355bdd3e7f724b860, agree it's clearer for these comments to refer to the greppable name of the limit rather than the number\n\nTree-SHA512: 462afc1c64543877ac58cb3acdb01d42c6d08abfb362802f29f3482d75401a2a8adadbc2facd222a9a9fefcaab6854865ea400f50ad60bec17831d29f7798afe","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2276112879\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30024\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30024/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30024\">#30024</a>: doc: replace remaining \"520\" magic nums with MAX_SCRIPT…"}},{"before":"70e4d6ff1d269abbda9dafae659e3da3ea17867a","after":"f9486de6a96b624982a2d45b895bfe4e865063d1","ref":"refs/heads/master","pushedAt":"2024-05-03T16:36:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30029: test: remove duplicate `WITNESS_SCALE_FACTOR` constant definition\n\naf3c18169a075222fe0795ab24b8b20ad5e30ae4 [test]: remove duplicate WITNESS_SCALE_FACTOR (ismaelsadeeq)\n\nPull request description:\n\n  Notice this while working on #29523\n\n  - `blocktools.py` and `messages.py` both define `WITNESS_SCALE_FACTOR` constant\n\n  https://github.com/bitcoin/bitcoin/blob/99d7538cdb2a0ab7a7a2116cd5f33b95fc52b00e/test/functional/test_framework/blocktools.py#L48\n\n  https://github.com/bitcoin/bitcoin/blob/99d7538cdb2a0ab7a7a2116cd5f33b95fc52b00e/test/functional/test_framework/messages.py#L68\n  - This PR deletes the one in `blocktools.py` and update the tests to only use `WITNESS_SCALE_FACTOR` from `messages.py`\n\nACKs for top commit:\n  maflcko:\n    ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4\n  sipa:\n    ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4\n  achow101:\n    ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4\n  glozow:\n    lgtm ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4\n  brunoerg:\n    ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4\n  willcl-ark:\n    ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4\n\nTree-SHA512: 6bd8060c9eea10e03940acee2aa4cd08e4e0afb6d26be3e6300ad405fd0af5b373a00e994eb39515a2dcafa1625562bcd57945049a84b9c9dcc7ea60c24f0911","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2277296785\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30029\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30029/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30029\">#30029</a>: test: remove duplicate <code>WITNESS_SCALE_FACTOR</code> constant …"}},{"before":"99d7538cdb2a0ab7a7a2116cd5f33b95fc52b00e","after":"70e4d6ff1d269abbda9dafae659e3da3ea17867a","ref":"refs/heads/master","pushedAt":"2024-05-03T13:55:01.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"ryanofsky","name":"Ryan Ofsky","path":"/ryanofsky","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7133040?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30026: refactor, test: Always initialize pointer\n\nbd2de7ac591d7704b79304089ad1fb57e085da8b refactor, test: Always initialize pointer (Hennadii Stepanov)\n\nPull request description:\n\n  This change fixes MSVC warning [C4703](https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4703).\n\n  All `DisableSpecificWarnings` dropped from `test_bitcoin.vcxproj` as all remained are inherited from `common.init.vcxproj`.\n\n  Required to simplify warning suppression porting to the CMake-based build system.\n\nACKs for top commit:\n  maflcko:\n    utACK bd2de7ac591d7704b79304089ad1fb57e085da8b\n  sipsorcery:\n    utACK bd2de7ac591d7704b79304089ad1fb57e085da8b.\n  ryanofsky:\n    Code review ACK bd2de7ac591d7704b79304089ad1fb57e085da8b\n\nTree-SHA512: 006db041d3c3697a77d9df14de86cf7c8a10804b45789df01268b2236cf6452e77dc57e89f5d5a6bc26d4b5cd483f0722d6035649c8a523b57954bb1fc810d0c","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2276590596\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30026\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30026/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30026\">#30026</a>: refactor, test: Always initialize pointer"}},{"before":"5127844cabbe50236abc8d55015692515c49315e","after":"99d7538cdb2a0ab7a7a2116cd5f33b95fc52b00e","ref":"refs/heads/master","pushedAt":"2024-05-03T07:31:13.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30012: opportunistic 1p1c followups\n\n7f6fb73c82fdff2afe5edefcc335ba6707d5627d [refactor] use reference in for loop through iters (glozow)\n6119f76ef72c1adc55c1a384c20f8ba9e1a01206 Process every MempoolAcceptResult regardless of PackageValidationResult (glozow)\n2b482dc1f3fb248ccbe7eeb8c9c07d4bf1295a70 [refactor] have ProcessPackageResult take a PackageToValidate (glozow)\nc2ada0530719e044bb498e0d78907a208214a71e [doc] remove redundant PackageToValidate comment (glozow)\n9a762efc7a118c44556fa9ad404f6b54103bad41 [txpackages] use std::lexicographical_compare instead of sorting hex strings (glozow)\n8496f69e1c2d1961db2604829cb6a289eb8dd3d6 [refactor] make MempoolAcceptResult::m_replaced_transactions non-optional (glozow)\n\nPull request description:\n\n  Followups from #28970:\n  - https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1568781077\n  - https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1585554972\n  - https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1581019326\n  - https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1581036209\n  - https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1586258730\n\nACKs for top commit:\n  instagibbs:\n    reACK https://github.com/bitcoin/bitcoin/pull/30012/commits/7f6fb73c82fdff2afe5edefcc335ba6707d5627d\n\nTree-SHA512: 9d8393d5f2fedbc6ebce582ff2a8ed074a02dd8e7dbf562c14d48b439fdc1ee6c3203b3609366d3c883d44655cc1a5c83a75ca56e490d25c1a34d95a0622d458","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2273446047\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30012\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30012/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30012\">#30012</a>: opportunistic 1p1c followups"}},{"before":"62ef33a718c9891d37d7c757968876033c4f794d","after":"5127844cabbe50236abc8d55015692515c49315e","ref":"refs/heads/master","pushedAt":"2024-05-03T02:47:42.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30017: refactor, fuzz: Make 64-bit shift explicit\n\nb50d127a7710d790c2ba4a08f01b832c2a0b1203 refactor: Make 64-bit shift explicit (Hennadii Stepanov)\n\nPull request description:\n\n  This PR fixes MSVC warning [C4334](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4334) in the fuzzing code. Similar to https://github.com/bitcoin/bitcoin/pull/26252.\n\n  All `DisableSpecificWarnings` dropped from `fuzz.vcxproj` as all remained are inherited from `common.init.vcxproj`.\n\n  Required to simplify warning suppression porting to the CMake-based build system.\n\nACKs for top commit:\n  maflcko:\n    utACK b50d127a7710d790c2ba4a08f01b832c2a0b1203\n  sipsorcery:\n    utACK b50d127a7710d790c2ba4a08f01b832c2a0b1203\n\nTree-SHA512: 18f6082b4234506ad2f9df54e577031b97cdf9f7ef64cad4162f275660716ab73587a97d3af0f778dfd48d2751d8676b5d3381d0aa837fcc60a09704473a9209","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2274355877\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30017\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30017/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30017\">#30017</a>: refactor, fuzz: Make 64-bit shift explicit"}},{"before":"81174d8a9b8060b35341d88d3b54c08d9f2bb079","after":"62ef33a718c9891d37d7c757968876033c4f794d","ref":"refs/heads/master","pushedAt":"2024-05-02T20:45:52.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29617: test: Validate UTXO snapshot with coin height > base height & amount > MAX_MONEY supply\n\nec1f1abfefa281e62bb876aa1c4738d576ef9a47 test:Validate UTXO snapshot with coin_height > base_height & amount > money_supply (jrakibi)\n\nPull request description:\n\n  ### Ensure snapshot loading fails for coins exceeding base height\n\n  **Objective**: This test verifies that snapshot loading is correctly rejected for coins with a height greater than the base height.\n\n  **Update**:\n  - Added `test_invalid_snapshot_wrong_coin_code` to `feature_assumeutxo.py`.\n  - The test artificially sets a coin's height above 299 in a snapshot and checks for load failure.\n  - Edit: Added a test case for outputs whose amounts surpass the MAX_MONEY supply limit.\n\n  This implementation addresses the request for enhancing `assumeutxo` testing as outlined in issue #28648\n\n  ---\n\n  **Edit: This is an explanation on how I arrive at content values: b\"\\x84\\x58\" and b\"\\xCA\\xD2\\x8F\\x5A\"**\n\n  You can use this tool to decode the utxo snapshot https://github.com/jrakibi/utxo-live\n  Here’s an overview of how it’s done:\n  The serialization format for a UTXO in the snapshot is as follows:\n  1. Transaction ID (txid) - 32 bytes\n  2. Output Index (outnum)- 4 bytes\n  3. VARINT (code) - A varible-length integer encoding the height and whether the transaction is a coinbase. The format of this VARINT is (height << 1) | coinbase_flag.\n  4. VARINT (amount_v) - A variable-length integer that represents a compressed format of the output amount (in satoshis).\n\n  For the test cases mentioned:\n  * **`b\"\\x84\\x58\"`** - This value corresponds to a VARINT representing the height and coinbase flag. Once we decode this code, we can extract the height and coinbase using `height = code_decoded >> 1` and `coinbase = code_decoded & 0x01`. In our case, with code_decoded = 728, it results in `height = 364` and `coinbase = 0`.\n  * **`b\"\\xCA\\xD2\\x8F\\x5A\"`** - This byte sequence represents a compressed amount value. The decompression function takes this value and translates it into a full amount in satoshis. In our case, the decompression of this amount translates to a number larger than the maximum allowed value of coins (21 million BTC)\n\nACKs for top commit:\n  fjahr:\n    re-ACK ec1f1abfefa281e62bb876aa1c4738d576ef9a47\n  maflcko:\n    ACK ec1f1abfefa281e62bb876aa1c4738d576ef9a4 👑\n  achow101:\n    ACK ec1f1abfefa281e62bb876aa1c4738d576ef9a47\n\nTree-SHA512: 42b36fd1d76e9bc45861028acbb776bd2710c5c8bff2f75c751ed505995fbc1d4bc698df3be24a99f20bcf6a534615d2d9678fb3394162b88133eaec88ca2120","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2178121326\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29617\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29617/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29617\">#29617</a>: test: Validate UTXO snapshot with coin height &gt; base he…"}},{"before":"3d28725134df09768780249dc1d974b9cdcc83f1","after":"81174d8a9b8060b35341d88d3b54c08d9f2bb079","ref":"refs/heads/master","pushedAt":"2024-05-02T20:33:29.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29961: refactor: remove remaining unused code from cpp-subprocess\n\n8b52e7f628304e83b0e36fd97e617de0f71c5a62 update comments in cpp-subprocess (check_output references) (Sebastian Falbesoner)\n97f159776ec06f767df1d4990aa7d0859140f52f remove unused method `Popen::kill` from cpp-subprocess (Sebastian Falbesoner)\n908c51fe4afeba0af500c6275027b1afa1b3bd19 remove commented out code in cpp-subprocess (Sebastian Falbesoner)\nff79adbe056220202f7a56d67f788c38fc49ef9f remove unused templates from cpp-subprocess (Sebastian Falbesoner)\n\nPull request description:\n\n  This PR removes remaining code that is unused within the cpp-subprocess module (templates and commented out code). Happy to add more removals if anyone finds more unused parts. Note that there are some API functions of the `Popen` class that we don't use, e.g. `wait()`, `pid()`, `poll()`, `kill()`, but they sound IMHO common enough to be useful in the future, so not sure how deep we should go there.\n\nACKs for top commit:\n  fjahr:\n    Code review ACK 8b52e7f628304e83b0e36fd97e617de0f71c5a62\n  achow101:\n    ACK 8b52e7f628304e83b0e36fd97e617de0f71c5a62\n  hebasto:\n    ACK 8b52e7f628304e83b0e36fd97e617de0f71c5a62.\n\nTree-SHA512: 14c1cd2216185d941923f06fdc7acbeed66cd87e2691d9a352f7309b3e07fe4877b580f598a2e4106f9c48395ed6de00a0bfb5d3c3af9c4624d1956a0f543e99","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2263956901\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29961\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29961/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29961\">#29961</a>: refactor: remove remaining unused code from cpp-subprocess"}},{"before":"9d1a286f20b8a602ffe72928bcd79be09fdbf9d0","after":"3d28725134df09768780249dc1d974b9cdcc83f1","ref":"refs/heads/master","pushedAt":"2024-05-02T13:09:20.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29968: refactor: Avoid unused-variable warning in init.cpp\n\nfa9abf968840745e428a86a9545aaa6c923415e2 refactor: Avoid unused-variable warning in init.cpp (MarcoFalke)\n\nPull request description:\n\n  Fixes https://github.com/bitcoin/bitcoin/pull/27679#discussion_r1580606777\n\nACKs for top commit:\n  TheCharlatan:\n    ACK fa9abf968840745e428a86a9545aaa6c923415e2\n\nTree-SHA512: dcf56d7aa68578ba611a2dc591de036ab1d08f7f4dfb35d325ecf7241d8e17abc0af7005b96c44da9777adc36961b4da7fdde282a1ab0e0a6f229c8108923101","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2265230312\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29968\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29968/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29968\">#29968</a>: refactor: Avoid unused-variable warning in init.cpp"}},{"before":"59b773f42a6730104e13904fb521e52023a997b5","after":"9d1a286f20b8a602ffe72928bcd79be09fdbf9d0","ref":"refs/heads/master","pushedAt":"2024-05-02T07:27:31.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29934: doc: add LLVM instruction for macOS < 13\n\n22574046c90c0662f3aa9b1baea074aff54f92a9 doc: add LLVM instruction for macOS < 13 (Sjors Provoost)\n\nPull request description:\n\n  #29208 bumped clang to 14, which users of old macOS versions need to install manually. This PR adds instructions.\n\n  Xcode 14.3.1 ships clang 14.0.3 (14.0.0 is broken, see #29918):\n  https://en.wikipedia.org/wiki/Xcode#Xcode_11.0_-_14.x_(since_SwiftUI_framework)\n\n  The system requirements for that is macOS Ventura 13.0 or later: https://developer.apple.com/documentation/xcode-release-notes/xcode-14_3_1-release-notes#\n\n  Homebrew itself officially supports macOS 12 or later, but _may_ still work on macOS 11: https://docs.brew.sh/Installation\n\n  Fwiw macOS 11 Big Sur last got an update in September 2023, so Apple has not _entirely_ written it off: https://en.wikipedia.org/wiki/MacOS_Big_Sur\n\nACKs for top commit:\n  maflcko:\n    utACK 22574046c90c0662f3aa9b1baea074aff54f92a9\n  TheCharlatan:\n    ACK 22574046c90c0662f3aa9b1baea074aff54f92a9\n\nTree-SHA512: 5b4bcc71966d1da84bc4da32da89e0dea9f519f37d9e14e169140c92af044b33f404f01ae7d10f53ab5345dd51ac404c161389efef93da5cacbfd52a43881695","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2256708313\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29934\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29934/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29934\">#29934</a>: doc: add LLVM instruction for macOS &lt; 13"}},{"before":"1cc3aa4d21e3e4ff7a651bc71fec062ec5a9eb09","after":"59b773f42a6730104e13904fb521e52023a997b5","ref":"refs/heads/master","pushedAt":"2024-05-02T03:45:29.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30010: lint: [doc] Clarify Windows line endings (CR LF) not to be used\n\nfa9be2f79520fff9cfe2ed35ace05cb322680af3 lint: [doc] Clarify Windows line endings (CR LF) not to be used (MarcoFalke)\n\nPull request description:\n\n  It has been this case since the linter was introduced years ago. Given a misunderstanding (https://github.com/bitcoin/bitcoin/pull/28074#issuecomment-2088028856), clarify the docs.\n\nACKs for top commit:\n  brunoerg:\n    ACK fa9be2f79520fff9cfe2ed35ace05cb322680af3\n\nTree-SHA512: be714db9df533e0962ed84102ffdb72717902949b930d58cf5a79cba36297f6b2b1f75e65a2c1f46bcb8e2f4ad5d025f3d15210f468a5ec9631a580b74f923ea","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2272997871\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30010\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30010/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30010\">#30010</a>: lint: [doc] Clarify Windows line endings (CR LF) not to…"}},{"before":"d73245abc70346a0e8805d50a1f395706084294c","after":"1cc3aa4d21e3e4ff7a651bc71fec062ec5a9eb09","ref":"refs/heads/master","pushedAt":"2024-05-02T03:21:30.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29707: depends: build miniupnpc with CMake\n\n5195baa60087ee366290887ad982fc491e14c111 depends: fix miniupnpc snprintf usage on Windows (fanquake)\n3c2d440f1497f60bb444326f51383df244dcdfe9 depends: switch miniupnpc to CMake (Cory Fields)\nf5618c79d9e7af05c2987044dc2da03697f8bb89 depends: add upstream CMake patch to miniupnpc (fanquake)\n6866b571ab96f03ca0775424e45458c5731f230f depends: miniupnpc 2.2.7 (fanquake)\n\nPull request description:\n\n  This picks up one of the changes from #29232, which is a switch to building miniupnpc with CMake. It includes an update to the most recent version of miniupnpc (2.2.7), which means we can drop one patch from that commit, and includes a new patch for a change I've upstreamed https://github.com/miniupnp/miniupnp/pull/721, as well as some suggestions from the previous PR.\n\nACKs for top commit:\n  theuni:\n    ACK 5195baa60087ee366290887ad982fc491e14c111.\n  TheCharlatan:\n    utACK 5195baa60087ee366290887ad982fc491e14c111\n\nTree-SHA512: 5b27e132cd5eed285e9be34c8b96893417d92a1ae55c99345c9a89e1c1c5e40e4bc840bc061b879758b2b11fcb520cd98c3da985c1e153f2e5380cf63efe2d69","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2202957329\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29707\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29707/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29707\">#29707</a>: depends: build miniupnpc with CMake"}},{"before":"842f7fdf786fcbbdf3df40522945813404f8a397","after":"d73245abc70346a0e8805d50a1f395706084294c","ref":"refs/heads/master","pushedAt":"2024-05-01T18:44:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29120: test: Add test case for spending bare multisig\n\ne504b1fa1fa4d014b329dea81bfdf1aa55db238f test: Add test case for spending bare multisig (Brandon Odiwuor)\n\nPull request description:\n\n  Fixes https://github.com/bitcoin/bitcoin/issues/29113\n\nACKs for top commit:\n  ajtowns:\n    ACK e504b1fa1fa4d014b329dea81bfdf1aa55db238f ; LGTM and just checking the 1-of-3 case seems fine\n  maflcko:\n    utACK e504b1fa1fa4d014b329dea81bfdf1aa55db238f\n  achow101:\n    ACK e504b1fa1fa4d014b329dea81bfdf1aa55db238f\n  willcl-ark:\n    reACK e504b1fa1fa4d014b329dea81bfdf1aa55db238f\n\nTree-SHA512: 641a12599efa34e1a3eb65b125318df326628fef3e6886410ea9e63a044664fad7bcad46d1d6f41ddc59630746b9963cedb569c2682b5940b32b9225883da8f2","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2050612886\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29120\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29120/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29120\">#29120</a>: test: Add test case for spending bare multisig"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAERTgoHwA","startCursor":null,"endCursor":null}},"title":"Activity · bitcoin/bitcoin"}