Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli_wallet to support unencrypted memo #2574

Open
1 of 17 tasks
abitmore opened this issue Jan 5, 2022 · 0 comments
Open
1 of 17 tasks

Update cli_wallet to support unencrypted memo #2574

abitmore opened this issue Jan 5, 2022 · 0 comments

Comments

@abitmore
Copy link
Member

abitmore commented Jan 5, 2022

Description

It is possible to use unencrypted memo:

* If @ref from == @ref to and @ref from == 0 then no encryption is used, the memo is public.
* If @ref from == @ref to and @ref from != 0 then invalid memo data

However, cli_wallet does not support it (btw: code duplication).

FC_ASSERT( _keys.count(memo->to) > 0 || _keys.count(memo->from) > 0,
"Memo is encrypted to a key ${to} or ${from} not in this wallet.",
("to", memo->to)("from",memo->from) );

FC_ASSERT( wallet._keys.count(memo->to) > 0 || wallet._keys.count(memo->from) > 0,
"Memo is encrypted to a key ${to} or ${from} not in this wallet.",
("to", memo->to)("from",memo->from) );

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Additional Context (optional)
Add any other context about the problem here.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added this to the 6.1.0 - Feature Release milestone Jan 5, 2022
@abitmore abitmore added this to To do in Feature Release (6.1.0) via automation Jan 5, 2022
@abitmore abitmore removed this from To do in Feature Release (6.1.0) Jul 31, 2022
@abitmore abitmore added this to To do in Feature Release (7.1.0) via automation Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant