Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion to rename "WindowedApp" to "GraphicalApp" #418

Open
KageKirin opened this issue Mar 6, 2019 · 9 comments
Open

Motion to rename "WindowedApp" to "GraphicalApp" #418

KageKirin opened this issue Mar 6, 2019 · 9 comments

Comments

@KageKirin
Copy link
Contributor

Hi,

related to the documentation PR #417, I'd like to motion to rename WindowedApp to GraphicalApp.
(I'm preparing a PR for this right now).

I'm open for comments and opinions about this.

PRO:

  • "win*" configuration term to only match "windows" (or "win32", "winstore" etc), not "WindowedApp"
  • using "vs*" for targeting "windows" seems a bit hazarduous, as technically VS can use other compilers more freely these days. I.e. technically, I could want to create VS projects using another compiler (e.g. android-clang, or some console-specific one) (and changes for this could go mostly into a customized version of BX's toolchain.lua).

CON:

  • unless allowing "WindowedApp" as exposed alias, this will be a breaking change. (Then again, nothing that a short sed call couldn't fix).

Regards.

@KageKirin
Copy link
Contributor Author

Ok, I made #419 as a WIP PR.

@bkaradzic
Copy link
Owner

cc @rhoot for 2nd opinion...

@rhoot
Copy link
Contributor

rhoot commented Mar 6, 2019

While I agree with the sentiment (win* vs vs*), this would be a huge breaking change. Enough so that I think it'd be a bad idea. The alias might work though.

@bkaradzic
Copy link
Owner

bkaradzic commented Mar 6, 2019

using "vs*" for targeting "windows" seems a bit hazarduous, as technically VS can use other compilers more freely these days.

Btw, just to clarify this. Using "vs*" means in VS IDE & VS build system (in the same way as gmake means make, not GCC), it doesn't imply compiler. In bx toolchain you can see that you can specify --vs=<compiler> which would explicitly set compiler, or in some cases it's possible to combine platforms together in the same solution that would use 2 different compilers depending on configuration choosen.

@bkaradzic
Copy link
Owner

Are you trying to have one application that could be compiled as ConsoleApp or WindowedApp by using some configuration option?

Not quite clear what you're trying to achieve. And I never seen need to do any configuration based on type of app that might change. Usually it's one or another, and then you just apply settings that are appropriate.

@KageKirin
Copy link
Contributor Author

KageKirin commented Mar 6, 2019

I had a few places where configuration was set to match 'WindowedApp' explicitely, and those were fine.
Main reason for me to be actually doing this, is that I got repeatedly bitten by my own forgetfulness setting of win* for windows only settings, rather than using vs* (reason for this is that I wanted to be able build for windows using gmake+clang as well).

@bkaradzic
Copy link
Owner

Ideally GENie would have something like: operating system / compiler / arch / cpu / crt / build system / IDE, and then you would be able to filter based on any of those.

@KageKirin
Copy link
Contributor Author

Sounds like a feasible idea.
Ideally, each 'category' would be prefixed to make filtering easier.
e.g. os-windows, os-linux, compiler-gcc, compiler-clang, compiler-msvc, arch-x86, arch-x64, arch-arm32, arch-arm64, ide-vs2019, ide-xcode10 etc.

Maybe for genie2? As these changes would be breaking backwards compatibility.

@bkaradzic
Copy link
Owner

bkaradzic commented Mar 7, 2019

Yeah, just slightly different: arch-32, arch-64, cpu-arm, cpu-x86. Also compiler-msvc-<version> would have to have version somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@KageKirin @bkaradzic @rhoot and others