-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for JsSymbol
#3489
Comments
hey @jedel1043, I'd like to work on this |
Sure! I'll assign it to you. Feel free to ping here or in our discord if you need any guidance. |
hey @jedel1043! From what I see the main way to test boa_engine is to interpret some JS code and then run assertions. I see that there's a file with some basic tests set up at I also see that some of well known symbols already have tests in other modules - Lastly, should I add any test cases for |
Yes! It would be really nice to have symbol tests centralized in that specific file.
Those tests only use symbols to access the object functions being tested, so I would say those are testing other things more than the symbols themselves.
Having native |
Sounds good! I'll then work on testing both JS code and native struct.
I get 404 when opening this link, not sure if the link is broken or I don't have permission to view it. |
That's weird, I tried opening it in a private window and it works... |
Yeah, that's weird. Well the direct link works, I'm looking through the tests. I'll see if I can implement something similar for |
No description provided.
The text was updated successfully, but these errors were encountered: