[Bug]: 1.21.1 /usr/share/doc/conky name mistake?

[0pLuS0]

What happened?

When I compile Conky from source in Linux 1.21.1 now has the /path named as; /usr/share/doc/conky-1.21.1-pre- that I copy the doc contents out of.

Previous versions were like this;

conky-1.19.6_pre
conky-1.20.1_pre

They use to always be as 'Version Number' _pre

Now in 1.21.1 (dash pre dash) -pre-

Which this seems a bit of odd naming.

Version

1.21.1

It would be nice in the next version updates the source compiled it as /usr/share/doc/conky-version

I never could understand all the _pre stuff...

THANKS

[brndnmtthws]

How did you install it? Generally the -pre stuff should be removed from the versioning when -DRELEASE=ON with CMake, as shown here:

conky/cmake/Conky.cmake

Lines 179 to 184 in 7526e7e

	if(RELEASE)
	set(VERSION "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}")
	else(RELEASE)
	set(VERSION
	"${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}-pre-${GIT_SHORT_SHA}")
	endif(RELEASE)

I'm trying to understand if this is a regression, or you just don't like the versioning on the docs dir.

Now that I think about it, it probably doesn't make sense to use the -pre and git sha in the version for the install path, so I might just remove that anyway.

[0pLuS0]

Hi @brndnmtthws

I am compiling Conky from source in Slackware, with a Slackware build script. I've actually been using this build script maybe for 2 years. DOCS are off; -DBUILD_DOCS=OFF

I have -DBUILD_DOCS=OFF because in Slack, you don't typically place docs under /usr/share but /usr/doc instead, that is why I am manually doing this and copying docs from the pre directory.

Unless i can turn it ON and all the docs are manually placed in /usr/share/docs with no need to copy from pre, and I just only need to make /usr/doc and then copy all the docs from /usr/share to /usr/doc?

I'm attaching the build script for you to see, it's actually called conky.SlackBuild

conky.SlackBuild.txt

THANKS

P.S.