Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup BaseTransitionModel #535

Open
zsoltk opened this issue Jul 17, 2023 · 0 comments
Open

Cleanup BaseTransitionModel #535

zsoltk opened this issue Jul 17, 2023 · 0 comments
Labels
appyx-interactions cleanup Something that's no longer needed and should be removed complexity: low P3 priority: low
Milestone
2.0

Comments

@zsoltk
Copy link
Contributor

zsoltk commented Jul 17, 2023

We have an excessive amount of related methods, do we really need all of them?

abstract fun ModelState.destroyedElements(): Set<Element<InteractionTarget>>

abstract fun ModelState.removeDestroyedElements(): ModelState

abstract fun ModelState.removeDestroyedElement(element: Element<InteractionTarget>): ModelState

abstract fun ModelState.availableElements(): Set<Element<InteractionTarget>>

FYI @KovalevAndrey
@zsoltk zsoltk added cleanup Something that's no longer needed and should be removed appyx-interactions P3 priority: low complexity: low labels Jul 17, 2023
@zsoltk zsoltk added this to the 2.0 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
appyx-interactions cleanup Something that's no longer needed and should be removed complexity: low P3 priority: low
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@zsoltk