Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions in README.md are dangerous #36

Closed
EchterAgo opened this issue Sep 28, 2018 · 6 comments · Fixed by #37
Closed

Instructions in README.md are dangerous #36

EchterAgo opened this issue Sep 28, 2018 · 6 comments · Fixed by #37

Comments

@EchterAgo
Copy link

The installation instructions result in an Electron Cash version 3.0 installation. Version 3.0 was released December of last year and is still affected by the JSONRPC security vulnerability. The instructions should be updated, I'd recommend removing information on how to install Electron Cash and only keeping information on how to install the plugin into an existing Electron Cash installation.

@EchterAgo
Copy link
Author

Generally the plugin installation process seems to be a lot smoother nowadays. I just posted on Electron-Cash/Electron-Cash/issues/869 about how to install the plugin and those instructions likely work for all platforms. Consider the text public domain, feel free to copy it.

@clifordsymack
Copy link
Collaborator

Hi @EchterAgo !

Thanks for this comment. I will update the installation part on README.

@EchterAgo
Copy link
Author

@chaintip 100 days

@clifordsymack
Copy link
Collaborator

Updated.

@EchterAgo
Copy link
Author

If you reopen this and close it with a pull request you can claim the tip I sent.

@chaintip
Copy link

0.00909355 BCH| ~ 4.96 USD has now been claimed by @clifordsymack when pull request #37 was merged. This will be sent to your wallet once you link it with chaintip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants