Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Butchery yield needs to be capped #4523

Open
RoyalFox2140 opened this issue Apr 24, 2024 · 3 comments
Open

Butchery yield needs to be capped #4523

RoyalFox2140 opened this issue Apr 24, 2024 · 3 comments
Labels

Comments

@RoyalFox2140
Copy link
Contributor

Describe the bug

Butchery yields is based on butchering quality which is good, but it has no cap to yield. With high enough quality you can gain more products than the creature weighs.

Steps To Reproduce

  1. Use a test item with a ridiculous butchering quality
  2. Find something to butcher
  3. Do it.

Screenshots

image
image
image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.3448 (22H2)
  • Game Version: 35a8baa [64-bit]
  • Graphics Version: Tiles
  • LAPI Version: 2
  • Game Language: English [en_US]
  • Mods loaded: [
    Bright Nights [bn],
    Craftable Gun Pack [craftgp],
    Alternative Map Key [alt_map_key],
    Fuji's Military Profession Pack [fuji_mpp],
    Craftable Bullet Casings [CasingCrafting],
    MST Extra [MST_Extra],
    Tankmod: Revived [Tankmod_Revived],
    Essence 2200 BN [Essence2200_BN],
    Essence 2200 Tweaks [FoxTweaks],
    No Addictions [No_Addictions],
    Limit Fungal Growth [limit_fungal_growth],
    Disable NPC Needs [no_npc_food],
    Simplified Nutrition [novitamins],
    OMT Resources [omt_resources],
    Flowing Water [flowing_water],
    No Filthy Clothing [no_filthy_clothing],
    Cataclysm++ [Cata++],
    No Wasps [No_Wasps]
    ]

Additional context

No response

@VissValdyr
Copy link
Contributor

VissValdyr commented Apr 25, 2024

Butcher quality is only affecting negative numbers. Butcher quality only affects speed. @Coolthulhu said so years ago. So this is a curious thing indeed.

@VissValdyr
Copy link
Contributor

But maybe for the low values we thing are adequate (till 50), so breaking it for the sake of breaking it... Not sure if it should be considered to be a bug then

@RoyalFox2140
Copy link
Contributor Author

A cap is essentially required because any bionics like the surgical scalpels, or any fictitious new item or furniture we add to increase butchery speed via high butchering quality is going to cause issues with preservation of mass, we could never add an Auto-Butcher furniture that gives 100% yield and in half the time of a human because there is no cap at 100%. (That is ignoring other limitations with power tools not using charges when used as a tool.)

A cap should also be one of the easiest changes to make so futureproofing the code here is worthwhile. We can't reasonably expect to always use 50 butchering quality for the remainder of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants