Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error test suites that exercise time-based conditions without defined time #1486

Open
haines opened this issue Mar 8, 2023 · 0 comments
Open

Error test suites that exercise time-based conditions without defined time #1486

haines opened this issue Mar 8, 2023 · 0 comments
Labels
area/api kind/enhancement New feature or request status/requires-design

Comments

@haines
Copy link
Member

haines commented Mar 8, 2023

options.now is not required in test suites, even if the tests exercise time-based conditions.

Perhaps we should be a bit stricter and error out if a test executes a time-based function and options.now is not provided?

Alternatively we could make this a warning, but I think an error is preferable to make flaky tests impossible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api kind/enhancement New feature or request status/requires-design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haines @charithe