enhancement(helm): Allow deploying as a DaemonSet #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1658 +/- ##
==========================================
- Coverage 53.59% 53.19% -0.41%
==========================================
Files 130 131 +1
Lines 14963 15303 +340
==========================================
+ Hits 8020 8140 +120
- Misses 6245 6456 +211
- Partials 698 707 +9 |
|
Please update the documentation at https://github.com/cerbos/cerbos/tree/main/docs/modules/deployment/pages and https://github.com/cerbos/cerbos/blob/main/docs/modules/ROOT/pages/installation/helm.adoc as well. Run |
Fixes cerbos#1640 Signed-off-by: Tristan Colgate-McFarlane <tristan@cerbos.dev>
gwatts
reviewed
Oct 2, 2023
|
|
||
| image:daemonset_deployment.png[DaemonSet model,role="center-img"] | ||
|
|
||
| * Each clusster node gets its own Cerbos instance — ensuring high performance and efficient resource usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support to the chart for deploying as a DaemonSet, and adds additional options
that are common in that scenario. The new settings are
type: defaults to deployment, but can be set to daemonsetpriorityClassName: allows setting the pod priorityClassNameservice.internalTrafficPolicy: allows forcing traffic to this service to the local pod instance.TODO:
Fixes #1640
git commit -s ...) to provide the DCO