Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support complex types #4325

Open
2 tasks
unnonouno opened this issue Feb 13, 2018 · 8 comments
Open
2 tasks

Support complex types #4325

unnonouno opened this issue Feb 13, 2018 · 8 comments
Labels
cat:feature Implementation that introduces new interfaces. prio:medium Medium priority. Should be worked on but does not require immediate action. roadmap Included in future roadmap.

Comments

@unnonouno
Copy link
Member

Currently Chainer assumes integers and floating point numbers. Now CuPy supports complex numbers. It's time to support complex numbers in Chainer.

  • Support complex numbers in gradient check
  • Support complex numbers in various functions
@unnonouno unnonouno added the cat:feature Implementation that introduces new interfaces. label Feb 13, 2018
@m3at
Copy link

m3at commented Feb 26, 2018

I'm curious about this, do you already have use-cases in mind or is that to broaden the capabilities of Chainer?
I see your related ongoing PR, does that target the reproduction of a specific paper?

@unnonouno
Copy link
Member Author

Yes. Some research papers use complex numbers or FFT. And i think it can be applied for speech processing. I want to improve capability of Chainer.

@m3at
Copy link

m3at commented Feb 27, 2018

Understood.
Thanks for the papers, I didn't know about the last two, seems very interesting!
Looking forward to use it in Chainer 👍

@hknerdgn
Copy link
Contributor

hknerdgn commented Mar 2, 2018

You should definitely look into https://arxiv.org/pdf/1701.00392.pdf as well.

@unnonouno
Copy link
Member Author

Thank you for a link!! Please thumb up this issue if you guys need this feature.

@toslunar
Copy link
Member

toslunar commented Jun 1, 2018

Should Chainer support "complex32" whose real/imag part is float16? It seems NumPy hasn't yet support "complex32".

@unnonouno
Copy link
Member Author

IMO, no, especially for the first implementation.

@kmaehashi kmaehashi added the roadmap Included in future roadmap. label Jun 25, 2018
@kmaehashi kmaehashi added the prio:medium Medium priority. Should be worked on but does not require immediate action. label Sep 3, 2018
@shivam7569
Copy link

I would like to work on this. Could anyone guide me with the process? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:feature Implementation that introduces new interfaces. prio:medium Medium priority. Should be worked on but does not require immediate action. roadmap Included in future roadmap.
Projects
None yet
Development

No branches or pull requests

6 participants