Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adangert/BitcoinCashWallet]: Show balance also in selected currency #21

Closed
chaintip opened this issue Mar 3, 2018 · 8 comments
Closed

Comments

@chaintip
Copy link
Owner

chaintip commented Mar 3, 2018

Repository: adangert/BitcoinCashWallet
Issue #8: Show balance also in selected currency


Total Bounty: 0.00396228 BCH| ~ 1.63 USD

To claim this bounty, get a pull request merged with @chaintip fixes #8 in the creation comment.

On-Chain Tips:

  • 0.00396228 BCH| ~ 1.63 USD from block-spider to return to sender when they link their wallet.

Pull Requests Fixing Issue:

@adangert
Copy link

adangert commented Mar 5, 2018

the pull request was merged in.

@adangert
Copy link

adangert commented Mar 5, 2018

it looks like the PR was merged after the comment was updated to include @chaintip and thus the bounty did not go through

@chaintip
Copy link
Owner Author

chaintip commented Mar 5, 2018

You can't tip a bounties issue... it creates all sorts of confusion :)

@chaintip
Copy link
Owner Author

chaintip commented Mar 5, 2018

I see, did you create the PR and merge it in a matter of seconds? I'm trying to work out what went wrong.

@chaintip chaintip closed this as completed Mar 5, 2018
@chaintip
Copy link
Owner Author

chaintip commented Mar 5, 2018

Ok, I marked it as unmerged in my database and then created a 'manual notification' so that it got processed. I'll add an issue about the timing issue. Do you remember how many seconds you waited from PR creation to PR merge?

@adangert
Copy link

adangert commented Mar 5, 2018

Yeah I created the PR, forgot the @ in the comment, merged it probably after like 10 seconds, then edited the comment to include the @ symbol, the chain tip bot then responded that once the PR was merged the bounty would go through, even though it was already merged.

@adangert
Copy link

adangert commented Mar 5, 2018

The problem may be the edit of the comment to include the @ symbol

@chaintip
Copy link
Owner Author

chaintip commented Mar 5, 2018

Ok, I don't cater for that but probably should. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants