Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 Bug - crew-launcher borked ("Add to launcher" button returns JS error in console on click) #15

Open
Vicky-Boi opened this issue Sep 7, 2023 · 8 comments
Assignees

Comments

@Vicky-Boi
Copy link

Vicky-Boi commented Sep 7, 2023

Describe the bug
When chrome-launcher add (package) is run, a chrome window pops up connecting to localhost. When the "Add to launcher" button is clicked, nothing happens.

To Reproduce
Steps to reproduce the behavior:

  1. I executed this command:

    $ crew-launcher add nautilus

    Output (shell):

    Unable to find an icon :/
    method return time=1694084938.470543 sender=:1.50 -> destination=:1.426 serial=8052 reply_serial=2
    

    Output (console):

    Uncaught TypeError: Cannot read properties of undefined (reading 'prompt')
    at HTMLButtonElement.<anonymous> (installer.js:17:22)
    

Expected behavior
A popup should've appeared prompting me to install the website/

Environment: Paste the output of crew sysinfo -v between the two *** below


Expand
  • Architecture: x86_64 (x86_64)

  • Processor vendor: GenuineIntel

  • User space: 64-bit

  • Chromebrew Kernel version: 5.4

  • Chromebrew Running in Container: false

  • Chromebrew version: 1.35.6

  • Chromebrew prefix: /usr/local

  • Chromebrew libdir: /usr/local/lib64

  • Last update in local repository: f9a4fccf Telegram 4.9.4 => 4.9.5 (#8616) (20 hours ago)

  • OS variant: Chrome OS

  • OS version: dedede-release/R116-15509.72.0

  • OS channel: stable-channel

@satmandu
Copy link
Member

satmandu commented Sep 7, 2023

@supechicken this is your wheelhouse...

@Vicky-Boi
Copy link
Author

Vicky-Boi commented Sep 7, 2023

Updated crew to the latest update d4ed8038 and upgraded my chromebook to v116. Nothing has changed, although this may not be relevant.

@supechicken supechicken self-assigned this Sep 12, 2023
@uberhacker
Copy link
Contributor

@supechicken, any potential solution to this issue?

@Ansh113130
Copy link

The command also dosent work for me
I ran it in crosh
chronos@localhost / $ crew-launcher add nautilus
bash: crew-launcher: command not found
Which ChromeOS Version are you on?

@Zopolis4
Copy link
Collaborator

This issue should also probably be transferred to the crew-launcher repo, right?

@Vicky-Boi
Copy link
Author

The "Help needed?" section in the crew-launcher repo gives a link to the issues page on this repository. If we are supposed to report issues there, then the link must be updated to that repo.

@Zopolis4
Copy link
Collaborator

@supechicken, crew-launcher is largely your project, what do you think?

@supechicken
Copy link
Member

@supechicken, crew-launcher is largely your project, what do you think?

I am okay with this...

@supechicken supechicken transferred this issue from chromebrew/chromebrew May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants