Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/fixup.rb does not handle removing deprecated packages properly. #9783

Open
Zopolis4 opened this issue May 13, 2024 · 0 comments · May be fixed by #9784
Open

lib/fixup.rb does not handle removing deprecated packages properly. #9783

Zopolis4 opened this issue May 13, 2024 · 0 comments · May be fixed by #9784
Assignees

Comments

@Zopolis4
Copy link
Collaborator

Describe the bug
When removing a deprecated package, lib/fixup.rb removes the files, but does not remove them from the list of installed packages.
This is due to an error in the code for writing to device.json

To Reproduce
Steps to reproduce the behavior:

  1. Please indicate where the command(s) were executed.

satmandu/crewbuild:amd64 docker image (Digest: sha256:c650cf0911bd7b9f4cca4d3289386dbb1d9f68e2765e37958459338096d152a3

  1. I executed the command(s) below:

    crew install js91
    crew update # Accept the removal of js91 here
    crew list installed | grep "js91"
    

    Output:

    chronos@67adfbd614ad /usr/local/lib/crew/packages $ crew update
    From https://github.com/chromebrew/chromebrew
     * branch                master     -> FETCH_HEAD
    HEAD is now at e62d1ce08 Vscodium 1.87.2.24072 => 1.89.1.24130 (#9780)
    Package lists, crew, and library updated.
    
    Js91 found in package fixup list
    Js91 is deprecated and should be removed.
    Js91: Replaced by newer versions of js.
    
    Would you like to remove deprecated package Js91? [y/N] y
    js91 removed!
    Checking for package updates...
    Your software is up to date.
    
    js91 # from the checking of crew list installed | grep "js91"
    

Expected behavior
That js91 is removed from the list of installed packages.

Expand
  • Architecture: x86_64 (x86_64)

  • Processor vendor: GenuineIntel

  • User space: 64-bit

  • Chromebrew Kernel version: 5.10

  • Chromebrew Running in Container: true

  • Chromebrew version: 1.48.1

  • Chromebrew prefix: /usr/local

  • Chromebrew libdir: /usr/local/lib64

  • Last update in local repository: e62d1ce Vscodium 1.87.2.24072 => 1.89.1.24130 (#9780) (33 minutes ago)

  • OS variant: Chrome OS

  • OS version: nocturne-release/R124-15823.40.0

  • OS channel: stable-channel

@Zopolis4 Zopolis4 self-assigned this May 13, 2024
@Zopolis4 Zopolis4 changed the title lib/fixup.rb does not handle removing deprecated packages lib/fixup.rb does not handle removing deprecated packages properly. May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant