-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: TestDynamicExporterLifecycle #32587
Labels
area/CI
Continuous Integration testing issue or flake
ci/flake
This is a known failure that occurs in the tree. Please investigate me!
sig/hubble
Impacts hubble server or relay
Comments
lmb
added
area/CI
Continuous Integration testing issue or flake
sig/hubble
Impacts hubble server or relay
ci/flake
This is a known failure that occurs in the tree. Please investigate me!
labels
May 16, 2024
Linking to the PR that added the functionality #28873 |
cc @marqc just in case it rings a bell. Fresh report, I don't think anyone looked into this yet. |
marqc
added a commit
to marqc/cilium
that referenced
this issue
Jun 10, 2024
In rare cases when dynamic exporter lifecycle Stop() function is called during config reload it may cause deadlock on mutex. This change stops config watcher ticker before locking the mutex, as mutex lock is effectively needed only to terminate configured exporters, not for retminating config watcher itself. Fixes: cilium#32587 Signed-off-by: Marek Chodor <mchodor@google.com>
4 tasks
marqc
added a commit
to marqc/cilium
that referenced
this issue
Jun 10, 2024
In rare cases when dynamic exporter lifecycle Stop() function is called during config reload it may cause deadlock on mutex. This change stops config watcher ticker before locking the mutex, as mutex lock is effectively needed only to terminate configured exporters, not for terminating config watcher itself. Fixes: cilium#32587 Signed-off-by: Marek Chodor <mchodor@google.com>
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 10, 2024
In rare cases when dynamic exporter lifecycle Stop() function is called during config reload it may cause deadlock on mutex. This change stops config watcher ticker before locking the mutex, as mutex lock is effectively needed only to terminate configured exporters, not for terminating config watcher itself. Fixes: #32587 Signed-off-by: Marek Chodor <mchodor@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
ci/flake
This is a known failure that occurs in the tree. Please investigate me!
sig/hubble
Impacts hubble server or relay
CI failure
The text was updated successfully, but these errors were encountered: