{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":16563587,"defaultBranch":"master","name":"cockroach","ownerLogin":"cockroachdb","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-02-06T00:18:47.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6748139?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1718148946.0","currentOid":""},"activityList":{"items":[{"before":"b98e51bc3a91cfbd732a6f7d09895993b2feea46","after":"27d56c006c17f462ca8be1fcb50894e437d864bb","ref":"refs/heads/blathers/backport-release-24.1-125507","pushedAt":"2024-06-11T23:35:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"opt: build constrained scans for LIKE patterns with escaped escapes\n\nTo build a tight constraint out of a constant LIKE pattern, we follow\nthese steps:\n\n1. call LikeEscape to convert the LIKE pattern to a regular expression\n2. call LiteralPrefix to get a constant prefix from the regex\n3. check if the regex consists solely of the prefix + \".*\"\n\nBefore step 3, we need to escape any special regex characters in the\nconstant prefix so that we can compare the prefix with the regex. We\nwere incorrectly using LikeEscape to do this, which was throwing an\nerror when the constant prefix contained special like pattern\ncharacters. Instead, use QuoteMeta which does exactly what we need.\n\nFixes: #124455\n\nRelease note (bug fix): Fix a bug in which constant LIKE patterns\ncontaining certain sequences of backslashes did not become constrained\nscans. This bug has been present since v21.1.13 when support for\nbuilding constrained scans from LIKE patterns containing backslashes was\nadded.","shortMessageHtmlLink":"opt: build constrained scans for LIKE patterns with escaped escapes"}},{"before":"f48128546802615a6cb3dfc1a06ac0ddddb23951","after":"b98e51bc3a91cfbd732a6f7d09895993b2feea46","ref":"refs/heads/blathers/backport-release-24.1-125507","pushedAt":"2024-06-11T23:35:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"Merge e6fda9a47205dcb436549209e2d0e17bc3bf7c99 into blathers/backport-release-24.1-125507","shortMessageHtmlLink":"Merge <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/cockroachdb/cockroach/commit/e6fda9a47205dcb436549209e2d0e17bc3bf7c99/hovercard\" href=\"https://github.com/cockroachdb/cockroach/commit/e6fda9a47205dcb436549209e2d0e17bc3bf7c99\"><tt>e6fda9a</tt></a> into blathers/backport-release-24.1-125507"}},{"before":"0d7110a85b5bbf0eb68bafd15abca076948b434e","after":"f48128546802615a6cb3dfc1a06ac0ddddb23951","ref":"refs/heads/blathers/backport-release-24.1-125507","pushedAt":"2024-06-11T23:35:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"tmp","shortMessageHtmlLink":"tmp"}},{"before":null,"after":"0d7110a85b5bbf0eb68bafd15abca076948b434e","ref":"refs/heads/blathers/backport-release-24.1-125507","pushedAt":"2024-06-11T23:35:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"Merge pull request #125524 from cockroachdb/blathers/backport-release-24.1-125490\n\nrelease-24.1: sql: deflake TestExperimentalRelocateNonVoters","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2347177965\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cockroachdb/cockroach/issues/125524\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cockroachdb/cockroach/pull/125524/hovercard\" href=\"https://github.com/cockroachdb/cockroach/pull/125524\">#125524</a> from cockroachdb/blathers/backport-release…"}},{"before":"f3dd38dc24d02070dad5864f7dc9041cfabf9634","after":"b2655ed2b845acbd3290acee50e17b78cc8af771","ref":"refs/heads/blathers/backport-release-23.2-125507","pushedAt":"2024-06-11T23:35:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"opt: build constrained scans for LIKE patterns with escaped escapes\n\nTo build a tight constraint out of a constant LIKE pattern, we follow\nthese steps:\n\n1. call LikeEscape to convert the LIKE pattern to a regular expression\n2. call LiteralPrefix to get a constant prefix from the regex\n3. check if the regex consists solely of the prefix + \".*\"\n\nBefore step 3, we need to escape any special regex characters in the\nconstant prefix so that we can compare the prefix with the regex. We\nwere incorrectly using LikeEscape to do this, which was throwing an\nerror when the constant prefix contained special like pattern\ncharacters. Instead, use QuoteMeta which does exactly what we need.\n\nFixes: #124455\n\nRelease note (bug fix): Fix a bug in which constant LIKE patterns\ncontaining certain sequences of backslashes did not become constrained\nscans. This bug has been present since v21.1.13 when support for\nbuilding constrained scans from LIKE patterns containing backslashes was\nadded.","shortMessageHtmlLink":"opt: build constrained scans for LIKE patterns with escaped escapes"}},{"before":"50aef544c08fabe8452d77f68c0ed60e07ffc7c1","after":"f3dd38dc24d02070dad5864f7dc9041cfabf9634","ref":"refs/heads/blathers/backport-release-23.2-125507","pushedAt":"2024-06-11T23:35:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"Merge e6fda9a47205dcb436549209e2d0e17bc3bf7c99 into blathers/backport-release-23.2-125507","shortMessageHtmlLink":"Merge <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/cockroachdb/cockroach/commit/e6fda9a47205dcb436549209e2d0e17bc3bf7c99/hovercard\" href=\"https://github.com/cockroachdb/cockroach/commit/e6fda9a47205dcb436549209e2d0e17bc3bf7c99\"><tt>e6fda9a</tt></a> into blathers/backport-release-23.2-125507"}},{"before":"5e47e80395a241ad41273357dc006b1598e6a425","after":"50aef544c08fabe8452d77f68c0ed60e07ffc7c1","ref":"refs/heads/blathers/backport-release-23.2-125507","pushedAt":"2024-06-11T23:35:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"tmp","shortMessageHtmlLink":"tmp"}},{"before":null,"after":"5e47e80395a241ad41273357dc006b1598e6a425","ref":"refs/heads/blathers/backport-release-23.2-125507","pushedAt":"2024-06-11T23:35:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"Merge pull request #125499 from cockroachdb/blathers/backport-release-23.2-125484\n\nrelease-23.2: changefeedccl: clear the registry cache in TestAvroWithRegionalTable","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2346767051\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cockroachdb/cockroach/issues/125499\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cockroachdb/cockroach/pull/125499/hovercard\" href=\"https://github.com/cockroachdb/cockroach/pull/125499\">#125499</a> from cockroachdb/blathers/backport-release…"}},{"before":"f1862eea1f0314806354766685e3aad47072884a","after":"f572a3e3913009fd5c81af3629237886a49457ce","ref":"refs/heads/blathers/backport-release-23.1-125507","pushedAt":"2024-06-11T23:35:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"opt: build constrained scans for LIKE patterns with escaped escapes\n\nTo build a tight constraint out of a constant LIKE pattern, we follow\nthese steps:\n\n1. call LikeEscape to convert the LIKE pattern to a regular expression\n2. call LiteralPrefix to get a constant prefix from the regex\n3. check if the regex consists solely of the prefix + \".*\"\n\nBefore step 3, we need to escape any special regex characters in the\nconstant prefix so that we can compare the prefix with the regex. We\nwere incorrectly using LikeEscape to do this, which was throwing an\nerror when the constant prefix contained special like pattern\ncharacters. Instead, use QuoteMeta which does exactly what we need.\n\nFixes: #124455\n\nRelease note (bug fix): Fix a bug in which constant LIKE patterns\ncontaining certain sequences of backslashes did not become constrained\nscans. This bug has been present since v21.1.13 when support for\nbuilding constrained scans from LIKE patterns containing backslashes was\nadded.","shortMessageHtmlLink":"opt: build constrained scans for LIKE patterns with escaped escapes"}},{"before":"c98cb11ab7650d0a9c1f28d170720afa426f036d","after":"f1862eea1f0314806354766685e3aad47072884a","ref":"refs/heads/blathers/backport-release-23.1-125507","pushedAt":"2024-06-11T23:35:36.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"Merge e6fda9a47205dcb436549209e2d0e17bc3bf7c99 into blathers/backport-release-23.1-125507","shortMessageHtmlLink":"Merge <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/cockroachdb/cockroach/commit/e6fda9a47205dcb436549209e2d0e17bc3bf7c99/hovercard\" href=\"https://github.com/cockroachdb/cockroach/commit/e6fda9a47205dcb436549209e2d0e17bc3bf7c99\"><tt>e6fda9a</tt></a> into blathers/backport-release-23.1-125507"}},{"before":"c4af5608c177888b6c5b88f46bf789b8b052d318","after":"c98cb11ab7650d0a9c1f28d170720afa426f036d","ref":"refs/heads/blathers/backport-release-23.1-125507","pushedAt":"2024-06-11T23:35:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"tmp","shortMessageHtmlLink":"tmp"}},{"before":null,"after":"c4af5608c177888b6c5b88f46bf789b8b052d318","ref":"refs/heads/blathers/backport-release-23.1-125507","pushedAt":"2024-06-11T23:35:35.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"Merge pull request #125498 from cockroachdb/blathers/backport-release-23.1-125484\n\nrelease-23.1: changefeedccl: clear the registry cache in TestAvroWithRegionalTable","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2346766851\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cockroachdb/cockroach/issues/125498\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cockroachdb/cockroach/pull/125498/hovercard\" href=\"https://github.com/cockroachdb/cockroach/pull/125498\">#125498</a> from cockroachdb/blathers/backport-release…"}},{"before":"f562d85d1533a4e103eb0199eda096d8c203b78b","after":"00d41392f1deb1d87e5b9e541f660ec8d04ccbb7","ref":"refs/heads/master","pushedAt":"2024-06-11T23:35:30.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"},"commit":{"message":"Merge #125507\n\n125507: opt: build constrained scans for LIKE patterns with escaped escapes r=yuzefovich a=michae2\n\nTo build a tight constraint out of a constant LIKE pattern, we follow these steps:\r\n\r\n1. call LikeEscape to convert the LIKE pattern to a regular expression\r\n2. call LiteralPrefix to get a constant prefix from the regex\r\n3. check if the regex consists solely of the prefix + \".*\"\r\n\r\nBefore step 3, we need to escape any special regex characters in the constant prefix so that we can compare the prefix with the regex. We were incorrectly using LikeEscape to do this, which was throwing an error when the constant prefix contained special like pattern characters. Instead, use QuoteMeta which does exactly what we need.\r\n\r\nFixes: #124455\r\n\r\nRelease note (bug fix): Fix a bug in which constant LIKE patterns containing certain sequences of backslashes did not become constrained scans. This bug has been present since v21.1.13 when support for building constrained scans from LIKE patterns containing backslashes was added.\n\nCo-authored-by: Michael Erickson <michae2@cockroachlabs.com>","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2346920763\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cockroachdb/cockroach/issues/125507\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cockroachdb/cockroach/pull/125507/hovercard\" href=\"https://github.com/cockroachdb/cockroach/pull/125507\">#125507</a>"}},{"before":"c09e37147db05f3a8a567fa8dfe1e5bab970d414","after":null,"ref":"refs/heads/staging.tmp","pushedAt":"2024-06-11T23:03:47.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"}},{"before":"71ce8ee0d5798faf37754805441175031dc1cd64","after":"5be227eb99e28ff9ba653f566c372187c9c6a6c3","ref":"refs/heads/blathers/backport-release-24.1-125452","pushedAt":"2024-06-11T23:03:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"roachtest: deflake disk-stall by moving monitor wait\n\nPreviously, we'd have the monitor wait for the workload(s)\nto complete _after_ we had stopped all the nodes. This resulted\nin flaky test behaviour if the workload ran for a bit longer\nthan the stall/unstall part(s) of the test, as the monitor\ncould catch the cockroach process terminating because we shut\nit down ourselves in the test. This change moves the monitor's\nwait method to be before the cluster.Stop call in the disk-stall/*\nroachtests, to avoid this failure case.\n\nFixes: #125292\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"roachtest: deflake disk-stall by moving monitor wait"}},{"before":"f562d85d1533a4e103eb0199eda096d8c203b78b","after":"00d41392f1deb1d87e5b9e541f660ec8d04ccbb7","ref":"refs/heads/staging","pushedAt":"2024-06-11T23:03:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"},"commit":{"message":"Merge #125507\n\n125507: opt: build constrained scans for LIKE patterns with escaped escapes r=yuzefovich a=michae2\n\nTo build a tight constraint out of a constant LIKE pattern, we follow these steps:\r\n\r\n1. call LikeEscape to convert the LIKE pattern to a regular expression\r\n2. call LiteralPrefix to get a constant prefix from the regex\r\n3. check if the regex consists solely of the prefix + \".*\"\r\n\r\nBefore step 3, we need to escape any special regex characters in the constant prefix so that we can compare the prefix with the regex. We were incorrectly using LikeEscape to do this, which was throwing an error when the constant prefix contained special like pattern characters. Instead, use QuoteMeta which does exactly what we need.\r\n\r\nFixes: #124455\r\n\r\nRelease note (bug fix): Fix a bug in which constant LIKE patterns containing certain sequences of backslashes did not become constrained scans. This bug has been present since v21.1.13 when support for building constrained scans from LIKE patterns containing backslashes was added.\n\nCo-authored-by: Michael Erickson <michae2@cockroachlabs.com>","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2346920763\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cockroachdb/cockroach/issues/125507\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cockroachdb/cockroach/pull/125507/hovercard\" href=\"https://github.com/cockroachdb/cockroach/pull/125507\">#125507</a>"}},{"before":"0d7110a85b5bbf0eb68bafd15abca076948b434e","after":"ecf7d555052bb0c1a6b6275368ea2ea61e47ecdb","ref":"refs/heads/blathers/backport-release-24.1-125452","pushedAt":"2024-06-11T23:03:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"tmp","shortMessageHtmlLink":"tmp"}},{"before":"ecf7d555052bb0c1a6b6275368ea2ea61e47ecdb","after":"71ce8ee0d5798faf37754805441175031dc1cd64","ref":"refs/heads/blathers/backport-release-24.1-125452","pushedAt":"2024-06-11T23:03:46.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"Merge 835326a0acc40ea13fd543b8aaf72132b58f72b4 into blathers/backport-release-24.1-125452","shortMessageHtmlLink":"Merge <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/cockroachdb/cockroach/commit/835326a0acc40ea13fd543b8aaf72132b58f72b4/hovercard\" href=\"https://github.com/cockroachdb/cockroach/commit/835326a0acc40ea13fd543b8aaf72132b58f72b4\"><tt>835326a</tt></a> into blathers/backport-release-24.1-125452"}},{"before":"ac395bcc4b2bba5d635673abf05f6b862595869e","after":"c09e37147db05f3a8a567fa8dfe1e5bab970d414","ref":"refs/heads/staging.tmp","pushedAt":"2024-06-11T23:03:45.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"},"commit":{"message":"[ci skip][skip ci][skip netlify] -bors-staging-tmp-125507","shortMessageHtmlLink":"[ci skip][skip ci][skip netlify] -bors-staging-tmp-125507"}},{"before":null,"after":"0d7110a85b5bbf0eb68bafd15abca076948b434e","ref":"refs/heads/blathers/backport-release-24.1-125452","pushedAt":"2024-06-11T23:03:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"blathers-crl[bot]","name":null,"path":"/apps/blathers-crl","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/59700?s=80&v=4"},"commit":{"message":"Merge pull request #125524 from cockroachdb/blathers/backport-release-24.1-125490\n\nrelease-24.1: sql: deflake TestExperimentalRelocateNonVoters","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2347177965\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cockroachdb/cockroach/issues/125524\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cockroachdb/cockroach/pull/125524/hovercard\" href=\"https://github.com/cockroachdb/cockroach/pull/125524\">#125524</a> from cockroachdb/blathers/backport-release…"}},{"before":null,"after":"ac395bcc4b2bba5d635673abf05f6b862595869e","ref":"refs/heads/staging.tmp","pushedAt":"2024-06-11T23:03:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"},"commit":{"message":"[ci skip][skip ci][skip netlify]","shortMessageHtmlLink":"[ci skip][skip ci][skip netlify]"}},{"before":"6ce16f4a546444f8428a2412c4c64e177653d8b7","after":"f562d85d1533a4e103eb0199eda096d8c203b78b","ref":"refs/heads/master","pushedAt":"2024-06-11T23:03:41.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"},"commit":{"message":"Merge #125452 #125519\n\n125452: roachtest: deflake disk-stall by moving monitor wait r=rickystewart a=itsbilal\n\nPreviously, we'd have the monitor wait for the workload(s) to complete _after_ we had stopped all the nodes. This resulted in flaky test behaviour if the workload ran for a bit longer than the stall/unstall part(s) of the test, as the monitor could catch the cockroach process terminating because we shut it down ourselves in the test. This change moves the monitor's wait method to be before the cluster.Stop call in the disk-stall/* roachtests, to avoid this failure case.\r\n\r\nFixes: #125292\r\n\r\nEpic: none\r\n\r\nRelease note: None\n\n125519: streamingccl: sort vtables by proc id r=rickystewart a=dt\n\nRelease note: none.\r\nEpic: none.\n\nCo-authored-by: Bilal Akhtar <bilal@cockroachlabs.com>\nCo-authored-by: David Taylor <tinystatemachine@gmail.com>","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2344851363\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cockroachdb/cockroach/issues/125452\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cockroachdb/cockroach/pull/125452/hovercard\" href=\"https://github.com/cockroachdb/cockroach/pull/125452\">#125452</a> <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2347104704\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cockroachdb/cockroach/issues/125519\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cockroachdb/cockroach/pull/125519/hovercard\" href=\"https://github.com/cockroachdb/cockroach/pull/125519\">#125519</a>"}},{"before":"e93962f4bbf7bc5e6d50ed5a5c10b609faa47ac0","after":null,"ref":"refs/heads/staging.tmp","pushedAt":"2024-06-11T22:34:27.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"}},{"before":"5a94f8e85b269b7827b9ca677a932f15a15bc19c","after":"f562d85d1533a4e103eb0199eda096d8c203b78b","ref":"refs/heads/staging","pushedAt":"2024-06-11T22:34:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"},"commit":{"message":"Merge #125452 #125519\n\n125452: roachtest: deflake disk-stall by moving monitor wait r=rickystewart a=itsbilal\n\nPreviously, we'd have the monitor wait for the workload(s) to complete _after_ we had stopped all the nodes. This resulted in flaky test behaviour if the workload ran for a bit longer than the stall/unstall part(s) of the test, as the monitor could catch the cockroach process terminating because we shut it down ourselves in the test. This change moves the monitor's wait method to be before the cluster.Stop call in the disk-stall/* roachtests, to avoid this failure case.\r\n\r\nFixes: #125292\r\n\r\nEpic: none\r\n\r\nRelease note: None\n\n125519: streamingccl: sort vtables by proc id r=rickystewart a=dt\n\nRelease note: none.\r\nEpic: none.\n\nCo-authored-by: Bilal Akhtar <bilal@cockroachlabs.com>\nCo-authored-by: David Taylor <tinystatemachine@gmail.com>","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2344851363\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cockroachdb/cockroach/issues/125452\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cockroachdb/cockroach/pull/125452/hovercard\" href=\"https://github.com/cockroachdb/cockroach/pull/125452\">#125452</a> <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2347104704\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cockroachdb/cockroach/issues/125519\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cockroachdb/cockroach/pull/125519/hovercard\" href=\"https://github.com/cockroachdb/cockroach/pull/125519\">#125519</a>"}},{"before":"3cd7e212f8b5ec9833bc990f75e844b39a9c8d17","after":"e93962f4bbf7bc5e6d50ed5a5c10b609faa47ac0","ref":"refs/heads/staging.tmp","pushedAt":"2024-06-11T22:34:26.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"},"commit":{"message":"[ci skip][skip ci][skip netlify] -bors-staging-tmp-125519","shortMessageHtmlLink":"[ci skip][skip ci][skip netlify] -bors-staging-tmp-125519"}},{"before":"9ccd0cc22d2cb98d89c02cb7a8b0c7eeee91d09f","after":"3cd7e212f8b5ec9833bc990f75e844b39a9c8d17","ref":"refs/heads/staging.tmp","pushedAt":"2024-06-11T22:34:25.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"},"commit":{"message":"[ci skip][skip ci][skip netlify] -bors-staging-tmp-125452","shortMessageHtmlLink":"[ci skip][skip ci][skip netlify] -bors-staging-tmp-125452"}},{"before":null,"after":"9ccd0cc22d2cb98d89c02cb7a8b0c7eeee91d09f","ref":"refs/heads/staging.tmp","pushedAt":"2024-06-11T22:34:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"},"commit":{"message":"[ci skip][skip ci][skip netlify]","shortMessageHtmlLink":"[ci skip][skip ci][skip netlify]"}},{"before":"d994f46e647cefd4ad25647d4444107d39062734","after":null,"ref":"refs/heads/staging.tmp","pushedAt":"2024-06-11T20:54:37.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"}},{"before":"7712c90d9962a8d44c39c9fd3803d251e9c2ace6","after":"5a94f8e85b269b7827b9ca677a932f15a15bc19c","ref":"refs/heads/staging","pushedAt":"2024-06-11T20:54:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"},"commit":{"message":"Merge #125519\n\n125519: streamingccl: sort vtables by proc id r=dt a=dt\n\nRelease note: none.\r\nEpic: none.\n\nCo-authored-by: David Taylor <tinystatemachine@gmail.com>","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2347104704\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cockroachdb/cockroach/issues/125519\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cockroachdb/cockroach/pull/125519/hovercard\" href=\"https://github.com/cockroachdb/cockroach/pull/125519\">#125519</a>"}},{"before":"61db8562cddff0bcdc77e43cf246c166b237d5af","after":"d994f46e647cefd4ad25647d4444107d39062734","ref":"refs/heads/staging.tmp","pushedAt":"2024-06-11T20:54:35.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"craig[bot]","name":null,"path":"/apps/craig","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10419?s=80&v=4"},"commit":{"message":"[ci skip][skip ci][skip netlify] -bors-staging-tmp-125519","shortMessageHtmlLink":"[ci skip][skip ci][skip netlify] -bors-staging-tmp-125519"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEYr4OUAA","startCursor":null,"endCursor":null}},"title":"Activity · cockroachdb/cockroach"}