Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: x/auth/tx and x/tx should converge on gogoproto usage. #20431

Open
kocubinski opened this issue May 20, 2024 · 3 comments
Open

[Refactor]: x/auth/tx and x/tx should converge on gogoproto usage. #20431

kocubinski opened this issue May 20, 2024 · 3 comments
Labels

Comments

@kocubinski
Copy link
Member

There is duplicate logic in both x/tx/decode and the x/auth/tx packages. Since the decision to support gogoproto throughout the SDK (as specified in core/transaction below)

Msg = gogoproto.Message

These two packages can be simplified and collapsed into one simple implementation in x/tx. An initial exploration of this was done here in #20424 and integrated in #20428.

The result will be a lot of deleted code and much less mental overhead when reasoning about transactions in the SDK. The signing code in x/tx can and should remain the same, as shown in #20424 reflection over gogotypes as input is possible through the use of dynamic messages.

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label May 20, 2024
@tac0turtle tac0turtle added C:x/tx and removed needs-triage Issue that needs to be triaged labels May 21, 2024
@noelukwa
Copy link
Contributor

@tac0turtle i would like to take on this

@tac0turtle
Copy link
Member

yes, we would love the help ❤️

@kocubinski
Copy link
Member Author

@noelukwa Great, #20424 has some preliminary work for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants