Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.7.0 #914

Closed
3 tasks done
starwed opened this issue May 27, 2015 · 22 comments
Closed
3 tasks done

Release 0.7.0 #914

starwed opened this issue May 27, 2015 · 22 comments

Comments

@starwed
Copy link
Member

starwed commented May 27, 2015

Ok, it's been far too long since a release, so lets start preparing for one! There have been some pretty large changes, so let's call this 0.7.

I just merged the develop branch into the testing branch -- no problems there, at least.

What issues are there blocking the release?

  • The introduction of the Motion component had pretty far reaching effects. There are a couple of related issues, so we should probably address them before an actual release.
  • Doing the doc revamp revealed some issues with the api docs. There are several broken links, some borked formatting, and some naming problems.
  • Various new components/methods should have their docs checked; previously it was really annoying to check the generated api docs, but the new grunt task in the develop branch should make that easier. (grunt view-api).
  • There have been some recent changes to make crafty more useful in node; that probably needs some testing Punting on this
  • Figure out the bower situation Punting on this

Anything else big?

@kevinsimper
Copy link
Contributor

Sound good!

@mucaho
Copy link
Contributor

mucaho commented May 30, 2015

WebGL is also big feature.
Will the iso improvements (backward compatible?, airza still working on it) and #902 be also included? Don't have much time currently, haven't had chance to look at iso improvements and finalize #902 .

@starwed
Copy link
Member Author

starwed commented Jun 2, 2015

Will the iso improvements (backward compatible?, airza still working on it) and #902 be also included?

  • iso: At least some of them -- I think the large changes should probably wait til the next release. (Sounds like it might take a bit of time to settle on an api for the iso stuff.)
  • 902: I guess this is mostly up to you and kevin -- I haven't tried using Crafty that way, so I don't have a good feel for what the current situation is.

@starwed
Copy link
Member Author

starwed commented Jun 2, 2015

Current status:

  • The doc issues are mostly taken care of in Fix numerous small documentation issues #918, although since the Motion-related components might still be in flux I haven't looked at their docs very closely.
  • I'm going to try to build a very simple platformer using the new motion-related components, to get to grips with how they work.
  • I don't think there are any WebGL related issues that block the release -- there are some places on the main site that should mention that as a feature, though.

@starwed
Copy link
Member Author

starwed commented Jun 11, 2015

We should sort out what we're going to do with Bower. (I think the general agreement is to use the Crafty-Distro repo for that, but I don't know the specifics of what we need to do to enable that.)

@starwed
Copy link
Member Author

starwed commented Jul 6, 2015

@mucaho @kevinsimper Ok, so the remaining big issues seem to be dealing with bower and node installation... any feedback on what the status is for them?

@mucaho
Copy link
Contributor

mucaho commented Jul 6, 2015

Node status: The majority of stuff is implemented in #902.

  • What is missing to fully support node is isometric stuff, which is still pending development (e.g. Proposed API for the DiamondIso component #917).
  • Additionally there are some minor things to be streamlined in future, but don't pose any problems.
  • We should add additional documentation flags to indicate what is available in node version and what isn't. This labels/flags should somehow be highlighted in the online API documentation.

My recommendation: This will take some time to implement, I can start serious hacking next week. We can delay node stuff to next release, as early adopters can use nightly builds anyway.

@starwed
Copy link
Member Author

starwed commented Sep 20, 2015

Sorry about disappearing for a while -- unexpectedly got a new (better) job in a new city, so I was pretty busy settling in!

I'm going to pull into testing again. I've been trying to at least keep an eye on any open issues, but some feedback would be good:

  • are there any bad bugs or important PRs that should be fixed/merged before cutting a new release?
  • Conversely, are there any new features that shouldn't be included in a release? (Waiting on incoming patches, etc.)
  • @Sythe2o0 You mentioned working on an isometric game, so I wanted to give you a heads up about some changes that landed a few months ago. It was PR Diamond improvements #897 if anyone wants to give feedback. (There's also an open PR Proposed API for the DiamondIso component #917 for proposed further changes, but we probably don't want to wait on that for a release.)
  • I'm ok punting on the node/bower issues, since they don't stop anyone from using crafty as it currently is used.

@starwed
Copy link
Member Author

starwed commented Sep 20, 2015

Added a beta release from the testing branch.

Feel free to add features to the list (I only spent a couple of seconds jotting some down) but I have a draft of the 0.7. new features somewhere -- I just have to find it!

@CubixSystem
Copy link

Hello all. @starwed in your beta release:

/**
 * crafty 0.6.3-beta
 * http://craftyjs.com/
 *
 * Copyright 2014, Louis Stowasser
 * Dual licensed under the MIT or GPL licenses.
 */

How I can check changes in isometric components? (I'm working on cnc like prototype and can test this components)

@starwed
Copy link
Member Author

starwed commented Sep 23, 2015

@CubixSystem If you checkout the git repo and have node+grunt set up, you can use grunt view-api to generate docs for whatever branch you're in. You could also read through the pull request I linked to, to see specifically what has changed.

I should also upload some docs to the main site for the beta -- I'll post back here once I've done that.

@starwed
Copy link
Member Author

starwed commented Oct 3, 2015

I compiled release notes of all the changes for this release -- let me know if something is missing, wrong, or you think should be more prominent.

@starwed
Copy link
Member Author

starwed commented Oct 3, 2015

Also compiled a second beta with some recent fixes.

@starwed
Copy link
Member Author

starwed commented Oct 3, 2015

@CubixSystem I generated docs for the beta. I'm not sure on exactly what changed, but you can see the new docs for diamondIso and isometric

@CubixSystem
Copy link

@starwed Thanks for this, at the moment I'm already move from last release to Crafty 0.7.0 Beta-2

@mucaho
Copy link
Contributor

mucaho commented Oct 21, 2015

@starwed
Thanks for your effort! I took a look at the changelog - it looks good.

On the iso stuff: The 2nd part of iso improvements by airza (#917, #925) are I think linked to the his/her previous modifications of iso stuff. It would be great if you could take a look too, and if everything checks out, probably merge it for current release.

On the node stuff:

  • I would have liked to add labels for "headless" stuff in the API docs for current release. Any ideas?
  • Contrary to my initial belief, isometric stuff should not be included in headless version as isometric should only be about the display. We should probably figure something out in the future in order to decouple isometric display from game logic (read about working prototype here). In the current release isometric stuff is not included.

@starwed
Copy link
Member Author

starwed commented Nov 8, 2015

On the iso stuff: The 2nd part of iso improvements by airza (#917, #925) are I think linked to the his/her previous modifications of iso stuff. It would be great if you could take a look too, and if everything checks out, probably merge it for current release.

I'm going to go ahead and do the release without them -- my understanding is that the existing iso functionality still works without them.

I would have liked to add labels for "headless" stuff in the API docs for current release. Any ideas?

I think we should have some sort of generic @tag attribute in the doc syntax -- that would make it pretty easy to add things like this. I think that can also wait for a later release, though. At this point getting a release out is probably the most important thing. We don't want it to look like the project is totally stagnant! :)

@starwed
Copy link
Member Author

starwed commented Nov 8, 2015

I went ahead and cut a release, pushing it live to craftyjs.com. I won't close this issue yet, because

  • Some of the non-auto-generated docs could use updating to mention essential new features
  • I imagine something has to happen to publish the node release on npm?

@mucaho
Copy link
Contributor

mucaho commented Nov 8, 2015

Good stuff! Yep, we need @kevinsimper to publish it, he is the author of the node project (maybe he could add you as a maintainer so you could also publish). What about bower?

@matthijsgroen
Copy link
Member

@mucaho Bower loads the file from dist/crafty.js

When i load 0.7.0 in bower I still get version 0.6.3 since the file in the dist folder has not been updated... 👎

@matthijsgroen
Copy link
Member

@mucaho
Copy link
Contributor

mucaho commented Nov 13, 2015

@matthijsgroen Thanks for checking that. I proposed a way of preventing this in future (#972). If that gets merged, then the next published crafty version should correctly be available via bower. (We could perhaps publish small dummy release to get bower package updated soon?),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants