Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add different colour for passive votes #2

Merged
merged 1 commit into from Apr 18, 2018
Merged

Add different colour for passive votes #2

merged 1 commit into from Apr 18, 2018

Conversation

DJMcNab
Copy link
Contributor

@DJMcNab DJMcNab commented Apr 16, 2018

Additionally, removes a surplus semicolon from python script
Switch to using bootstrap background colours
Refactor index script slightly - remove missing var statements and only loop through votes once.

@chaintip fixes #1

Remove a semicolon from python script
Switch to using bootstrap background colours
Refactor index script
@dagurval
Copy link
Owner

This look awesome! Thanks for doing this enhancement, and also for taking the time to improve the code in general.

I'll merge this as soon as I get confirmation that chaintip is working (chaintip/chaintip-github#32)

@DJMcNab
Copy link
Contributor Author

DJMcNab commented Apr 17, 2018

Is changing the url in fetch to 'https://bip100.tech/period/' OK. I only did it for testing purposes, but I don't think there's any reason it shouldn't be?

@chaintip
Copy link

If this pull request is merged to fix issue #1 first, @DJMcNab will claim the 0.01608291 BCH| ~ 13.46 USD bounty and all future tips to the issue.

@dagurval dagurval merged commit 3075c7c into dagurval:master Apr 18, 2018
@chaintip
Copy link

Nice work @DJMcNab! Your pull request has been merged and the bounty of 0.01608291 BCH| ~ 14.38 USD has been sent to your wallet.

@dagurval
Copy link
Owner

dagurval commented Apr 18, 2018

Is changing the url in fetch to 'https://bip100.tech/period/' OK. I only did it for testing purposes, but I don't think there's any reason it shouldn't be?

It gets real confusing if you're testing it out on a local node.

Your PR is now live on https://bip100.tech, thanks!

@DJMcNab
Copy link
Contributor Author

DJMcNab commented Apr 18, 2018

No problem. I did forget about testing it with a local node. (I only tested using the live data)

I'm glad I found the project, it's an interesting website and technology.

@dgenr8
Copy link

dgenr8 commented Apr 18, 2018

Thanks @DJMcNab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color active votes in different shade of blue
4 participants