Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization of txids missing a character #1

Closed
dagurval opened this issue Apr 16, 2018 · 3 comments
Closed

Visualization of txids missing a character #1

dagurval opened this issue Apr 16, 2018 · 3 comments

Comments

@dagurval
Copy link
Owner

dagurval commented Apr 16, 2018

In Flowee I have double-spend detection as well, which is needed for some
other components like a point-of-sale solution build on Flowees APIs. So
when I noticed this in my logs today I thought I'd check if we got the same
data;
16:17:54 [2501] Double spend found
b86a8a170b55ebb516dd5dde036b85b4acea25a26de8e83ee0764757ec94c851
acb4eb8a07b6124fe14903bed92ce653081f0e0ca439a2d983154609e3fb3ceb·

I noticed that the '1' and the 'b' were missing at the end of your version
of events. But the clickable link has it, so its purely a minor rendering
issue.

(Thanks for the report @zander)

This is possibly off-by-one error in https://github.com/dagurval/doublespend.cash/blob/master/respend/websitebuilder.py#L128

@chaintip 120 days

@dagurval dagurval changed the title Off by one error in tx hash Visualization of txids missing a character Apr 16, 2018
@DJMcNab
Copy link

DJMcNab commented Apr 18, 2018

Is it possibly just the :-1 on:

suffix = txid[-3:-1]

It should be txid[-3:]

See:

"test"[:-1] == "tes"

Unless I'm mistaken, I'd say it hardly seems worth the bounty for you, to me. I'll give you this for free.

@dagurval
Copy link
Owner Author

Thanks @DJMcNab. I'll save it for the bounty for a new issue :-)

@chaintip
Copy link

0 BCH| ~ 0.00 USD has now been tipped to this issue.
To claim this bounty, get a pull request merged with @chaintip fixes #1 in the creation comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants