-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoshGit / ugit Compatibility Issues #912
Comments
Updating GitUtils.ps1: (Fixing ugit compatibility issue #912)
Agree! I'll ship a new version as soon as I can get a few lingering PRs merged. |
Cool! It occurs to me that you might rely on git output being text in other places. So while this might have gotten rid of the most obvious breaking change, it's possible there are others. It would be fairly trivial for you to save Doing this should prevent any future hijinks. |
I assume you mean |
Sorry for the delay in response (and the typo). Yes, $executionContext is faster than Get-Command. I'll add a Benchmark on this to Benchpress. On my box, here's what the results were:
|
It's so cool to see two awesome projects collaborating together! 😄 I'm looking forward to when this fix will be released as it is affecting me as well right now. |
System Details
Issue Description
posh-git has a compatibility issue with ugit.
This is because ugit overrides git with a PowerShell command.
While this does support any number of arguments, PowerShell can get confused when dealing with short argument names.
Thus line 331 in Get-GitStatus blows up the prompt.
The solution for this works just fine if ugit is loaded or not.
Quote the single character arguments:
Since posh-git is already very useful, but doesn't return git naturally as objects, it makes sense for both modules to work together in concert.
The text was updated successfully, but these errors were encountered: