Store buffer verification code triggers #55754
Comments
mkustermann
added
area-vm
copybara-service bot
pushed a commit
that referenced
this issue
May 17, 2024
This reverts commit bc0f02e. Reason for revert: #55754 Original change's description: > [vm, gc] Incremental compaction. > > At the beginning of a major GC cycle, select some mostly-empty pages to be evacuated. Mark the pages and the objects on these pages. Apply a write barrier for stores creating old -> evacuation candidate pointers, and discover any such pointers that already exist during marking. > > At the end of a major GC cycle, evacuate objects from these pages. Forward pointers of objects in the remembered set and new-space. Free the evacuated pages. > > This compaction is incremental in the sense that creating the remembered set is interleaved with mutator execution. The evacuation step, however, is stop-the-world. > > Write-barrier elimination for x.slot = x is removed. Write-barrier elimination for x.slot = constant is removed in the JIT, kept for AOT but snapshot pages are marked as never-evacuate. > > TEST=ci > Bug: #52513 > Change-Id: Icbc29ef7cb662ef8759b8c1d7a63b7af60766281 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357760 > Reviewed-by: Alexander Aprelev <aam@google.com> > Commit-Queue: Ryan Macnak <rmacnak@google.com> Bug: #52513 Change-Id: I565ad6c0fca283d33f605c10f181bc0a59e7d2b2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366965 Reviewed-by: Ryan Macnak <rmacnak@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alexander Aprelev <aam@google.com> Auto-Submit: Ryan Macnak <rmacnak@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 17, 2024
… ARM/ARM64. Add missing store barrier check for RISCV. TEST=ci Bug: #55754 Change-Id: I90156c5fbb9f49b26ef19319dde7899b512670d7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366894 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 20, 2024
…ialization. TEST=ci Bug: #55754 Change-Id: Ie516be52a8edf620019f60b2ea0fd4f3eeeba533 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367203 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 21, 2024
- Fix missing store buffer flush when --marker_tasks=0. - Fix passing untagged pointer to store barrier check on ARM/ARM64 (6bc417d). - Fix passing uninitialized header to store barrier check on ARM64/RISCV (1447193). TEST=ci Bug: #52513 Bug: #55754 Change-Id: Id2aa95b6d776b82d83464cde0d00e6f3b29b7b77 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367202 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 23, 2024
This reverts commit 9077bf9. Reason for revert: CBuild and TGP crashes in random Dart code which look a lot like arbitrary memory corruption. Original change's description: > [vm, gc] Incremental compaction, take 2. > > - Fix missing store buffer flush when --marker_tasks=0. > - Fix passing untagged pointer to store barrier check on ARM/ARM64 (6bc417d). > - Fix passing uninitialized header to store barrier check on ARM64/RISCV (1447193). > > TEST=ci > Bug: #52513 > Bug: #55754 > Change-Id: Id2aa95b6d776b82d83464cde0d00e6f3b29b7b77 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367202 > Commit-Queue: Ryan Macnak <rmacnak@google.com> > Reviewed-by: Alexander Aprelev <aam@google.com> Bug: #52513 Bug: #55754 Change-Id: I1d70d33c65fe6bf7089b8c1422d59f9146ae7ebf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367962 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Slava Egorov <vegorov@google.com> Auto-Submit: Daco Harkes <dacoharkes@google.com> Commit-Queue: Slava Egorov <vegorov@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 29, 2024
This reverts commit 9077bf9. Reason for revert: CBuild and TGP crashes in random Dart code which look a lot like arbitrary memory corruption. Original change's description: > [vm, gc] Incremental compaction, take 2. > > - Fix missing store buffer flush when --marker_tasks=0. > - Fix passing untagged pointer to store barrier check on ARM/ARM64 (6bc417d). > - Fix passing uninitialized header to store barrier check on ARM64/RISCV (1447193). > > TEST=ci > Bug: #52513 > Bug: #55754 > Change-Id: Id2aa95b6d776b82d83464cde0d00e6f3b29b7b77 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367202 > Commit-Queue: Ryan Macnak <rmacnak@google.com> > Reviewed-by: Alexander Aprelev <aam@google.com> Bug: #52513 Bug: #55754 Change-Id: Iac70de4a56e8ce0916eff7defec1e085733d52ff Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/367962 Cherry-pick-request: #55867 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368620 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 30, 2024
- Use atomics to mark remembered cards in the write barrier stub. TEST=ci Bug: #52513 Bug: #55754 Change-Id: I1f78c6b680a6ae9170613ba328a244335a6343e2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368480 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From this failure:
I also see some flaky crashes on flakiness dashboard hitting breakpoint instrucions (e.g. this one in kernel isolate)
It may very well be because of the recent GC changes that landed.
/cc @rmacnak-google Maybe we should revert those for the time being (@mraleph @a-siva )
The text was updated successfully, but these errors were encountered: