[CP] Fix dart run missing fast path when using Flutter
#55758
Assignees
Labels
area-dart-cli
Use area-dart-cli for issues related to the 'dart' command like tool.
cherry-pick-approved
Label for approved cherrypick request
cherry-pick-review
Issue that need cherry pick triage to approve
dart-cli-run
Issues related to 'dart run'
Comments
sigurdm
added
the
cherry-pick-review
lrhn
added
area-dart-cli
|
@jonasfj @jakemac53 could you take a look at this cherry-pick request? |
|
LGTM |
itsjustkevin
added
the
cherry-pick-approved
copybara-service bot
pushed a commit
that referenced
this issue
May 21, 2024
Changes: ``` > git log --format="%C(auto) %h %s" ed20b45..9d10254 https://dart.googlesource.com/pub.git/+/9d102541 Fix flutter version update on fast path (4272) ``` Diff: https://dart.googlesource.com/pub.git/+/ed20b45589766d6fd135e93460b9e8255ccba519..9d1025414395db2dac9d590d2e567c27064783d2/ Change-Id: I57202cc00adc2c11cda05e9ad9c5b97af9c46deb Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/367024 Cherry-pick-request: #55758 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367060 Reviewed-by: Jonas Jensen <jonasfj@google.com> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit(s) to merge
dart-lang/pub@e70850b
Rolled to the sdk in: https://dart-review.googlesource.com/c/sdk/+/367024?tab=checks
Target
stable
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/367060
Issue Description
Without this it is hard/impossible to use build_runner together with localization on flutter.
dart run build_runner buildwould wrongly think that the current resolution is stale, and redo it. Missing the flutter_gen package thatflutter pub getinjects to the package config.This is a regression that was introduced in: dart-lang/pub#4160 rolled to the sdk in 74c94ee
See dart-lang/build#3705
What is the fix
By fixing the fast-path check, we will not replace the package_config if it is up-to-date.
This does not fix the underlying problem that
dart rundoesn't inject the flutter_gen package when the resolution is stale, but at least makes it possible to run build_runner when localization is enabled.Why cherry-pick
To fix the regression
Risk
Medium-low
Issue link(s)
See dart-lang/build#3705
Extra Info
No response
The text was updated successfully, but these errors were encountered: