Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macros: expose isConst on ConstructorDeclaration #55768

Open
felangel opened this issue May 18, 2024 · 1 comment
Open

Macros: expose isConst on ConstructorDeclaration #55768

felangel opened this issue May 18, 2024 · 1 comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. feature-macros Implementation of the macros feature pkg-macros The experimental package:_macros library

Comments

@felangel
Copy link

felangel commented May 18, 2024 •
edited

Currently it's not possible to determine whether a constructor is a const constructor or not when building a macro.
I would love to see isConst exposed via ConstructorDeclaration alongside isFactory

sdk/pkg/_macros/lib/src/api/introspection.dart

Line 286 in 6bc417d

bool get isFactory;
.
@felangel felangel changed the title [Feature Request] Expose isConst on ConstructorDeclaration [Macros] expose isConst on ConstructorDeclaration May 18, 2024
@felangel felangel changed the title [Macros] expose isConst on ConstructorDeclaration Macros: expose isConst on ConstructorDeclaration May 18, 2024
@lrhn lrhn added area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. feature-macros Implementation of the macros feature pkg-macros The experimental package:_macros library labels May 19, 2024
@davidmorgan
Copy link
Contributor

Thanks! This is useful to come back to but not super high priority right now so I'll move it to the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. feature-macros Implementation of the macros feature pkg-macros The experimental package:_macros library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lrhn @davidmorgan @felangel