Relative position of globals #1304
Comments
|
@AJenbo great you started this issue to track the progress of mapping the global variables to their original addresses. I agree, getting relative offsets correct first seems like the way to go. Also, we should consider merging @Predelnik fix for the last function, even if it is still not bin perfect, it has the same size with minimal differences which is great for getting the offsets right. Regarding:
This is tracked by https://github.com/sanctuary/notes/issues/253 Updating the names of sanctuary/notes to use the original names of Diablo (and those used in Devilution) is not there yet, far from it. But it is definitely the direction to go. |
|
Other issues I see in the code region is the missing delete operator in appfat. Galaxy mentioned that it probably comes from Storm. It's the very first function in the .text section. The other issue is the size of pkware and probably also its position. And then off cause that read only globals should be marked as const. |
We did have the delete operator in there at some point. I think it was one of my first PRs to the project. #110
Isn't pkware open source? Perhaps not. If it is, then with some luck we should get it to be bin exact quite easily.
This should be an easy one. |
On the topic of getting correct memory layout I think one place to start is correcting the relative order of the global variables. For me the biggest gap of knoleage is how the globals are positioned in the roginal exe. There is the documentation at https://github.com/sanctuary/notes but our naming is different so it would need some work and also I'm not really sure how best to pase the text format in order to sort them by memory address.
This appears to be the current order of our global variables:
The text was updated successfully, but these errors were encountered: