Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max fingerprint percentage does not work #1163

Closed
AndreyNikitin opened this issue Jun 30, 2023 · 3 comments
Closed

Max fingerprint percentage does not work #1163

AndreyNikitin opened this issue Jun 30, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@AndreyNikitin
Copy link

Currently -M flag does not work.
If use any amount less than 100 of the flag report fails with error Kgram hash not found
Broken in commit 1db346e

@rien rien added the bug Something isn't working label Jun 30, 2023
@rien
Copy link
Member

rien commented Jun 30, 2023

Thank you for reporting. Unfortunately, I am not able to reproduce the error, but I do notice that adding a maximum percentage has no effect so there is definitely something broken.

Can you try to see if you're able to reproduce the error with our simple-dataset.zip? If so, can you list the exact command line prompt you've used?

Can you also show the output of dolos --version and which system you're on?

@AndreyNikitin
Copy link
Author

AndreyNikitin commented Jul 3, 2023

For example,

yarn dolos run  -l "char" -M 0.01 -f csv simple-dataset/info.csv -o 01/

result in 01 folder

yarn run dolos serve 01

You can see errors on looking at the pairs screen http://localhost:3000/#/pairs/147

I checked on latest commit of main branch of the current repository

@rien
Copy link
Member

rien commented May 31, 2024

We have added experimental support for ignoring template code and frequent fingerprints in PR #1524

@rien rien closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants