Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickering caused by age seconds #1240

Open
beelze opened this issue Dec 12, 2023 · 5 comments
Open

Flickering caused by age seconds #1240

beelze opened this issue Dec 12, 2023 · 5 comments

Comments

@beelze
Copy link

beelze commented Dec 12, 2023

dunst 1.9.2, cinnamon, Gentoo

Changing age every second causing flickering sometimes (especially when high number of notification are displayed). As far as I understand, that is because of changing length of XYm YYs old string, like 10m 59s11m 0s, 15m 9s15m 10s and so on.

Notification height may change this moment, causing redraw of notification itself and moving other notifications up and down. I believe this issue can be fixed by suppressing seconds in age string after some (configurable) age. For instance, 20m old instead of 20m 15s old may be enough in most scenarios. Something like short_age_after=<time> configurable option. Consider this as FR please.

@bynect
Copy link
Member

bynect commented Dec 18, 2023

Is the problem that when the time string gets too long the layout is skewed and everything is shifted below, thus causing a total redraw?

@beelze
Copy link
Author

beelze commented Dec 18, 2023

Yes. Indicating the age of notification is a good idea, but implementing this by adding variable string to notification body is controversial.

@bynect
Copy link
Member

bynect commented Dec 20, 2023

Yes. Indicating the age of notification is a good idea, but implementing this by adding variable string to notification body is controversial.

Maybe we can use a fixed length template so that redraws at most will change text layout but not notification size

@beelze
Copy link
Author

beelze commented Dec 20, 2023

Maybe we can use a fixed length template so that redraws at most will change text layout but not notification size

Surely it will solve the most of the issue

@fwsmit
Copy link
Member

fwsmit commented Jan 14, 2024

The issue is that dunst is flickering on redraw. This is probably not so easy to solve on X11, but should not happen on wayland. It can be mitigated with not updating every second after a while. I would be fine with just showing the number of minutes after the notification is more than a minute old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants