fix(slo): Force using exactly one rolling window as date range by default #183754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kdelemme
added
release_note:skip
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
botelastic
bot
added
the
ci:project-deploy-observability
kdelemme
force-pushed
the
slo/integration-test-fail
branch
from
8594b14
to
ecf29c7
Compare
kdelemme
commented
May 17, 2024
| @@ -14,7 +14,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
| // failsOnMKI, see https://github.com/elastic/kibana/issues/180481 | |||
| describe('Trained models list', function () { | |||
| this.tags(['failsOnMKI']); | |||
|
|
|||
There was a problem hiding this comment.
@elastic/ml-ui CI auto commited this for you to review 😅
mgiota
reviewed
May 17, 2024
| @@ -46,7 +46,7 @@ const generateEsResponseForRollingSLO = (slo: SLODefinition, overridedRange?: Da | |||
| ? rollingDurationInDays + overridedRangeInDays | |||
| : rollingDurationInDays * 2; | |||
| const numberOfBuckets = fullDuration * bucketsPerDay; | |||
| const startDay = moment().subtract(fullDuration, 'day').startOf('day'); | |||
| const startDay = moment().subtract(fullDuration, 'day').startOf('minute'); | |||
There was a problem hiding this comment.
@kdelemme Now that you changed to startOf('minute'), maybe you would like to change the name of the current startDay variable? Would startMinute make sense or is it still startDay?
There was a problem hiding this comment.
I guess startRange would be even better
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.15.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #183748
Summary
This changes the start date for both ranges used in the historical summary. We now use the
startOf("minute")instead ofstartOf("day")for the start range.It makes the number of buckets deterministic, e.g. always 7d * 24buckets/d = 168 buckets, or 30d * 6buckets/d = 180 buckets.
Previously, by defining the range as
now.minus(7d).startOf("day")tonow.startOf("minutes"), we were using different range duration depending on the time of the day.