Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-vite - Error: Cannot copy '../which/bin/node-which' to a subdirectory of itself, '../which/bin/node-which'. #3602

Open
3 tasks done
gorillamoe opened this issue May 19, 2024 · 0 comments

Comments

@gorillamoe
Copy link

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

7.4.0

Electron version

v30.0.6

Operating system

Pop!_OS by System76 (Latest)

Last known working Electron Forge version

Bare version with just HTML and JS, e.g. No Vite + TS

Expected behavior

npm run make does not error out on Linux & Mac & Windows in CI with Vite + TS.

Actual behavior

npm run make DOES error out on Linux & Mac in CI.

Steps to reproduce

  1. git clone https://github.com/mistweaverco/timetrack && cd timetrack
  2. git checkout v3.3.0
  3. npm ci
  4. npm run make

Additional information

Seems to be due to a bug in fs-extra in the vite-plugin.

image

I patched it here for my project, but probably you guys and girls can also fork fs-extra and patch it and use your patched version of it?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants