Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds context menu option "Paste Selected" #557

Closed
wants to merge 7 commits into from
Closed

Adds context menu option "Paste Selected" #557

wants to merge 7 commits into from

Conversation

etkaar
Copy link
Contributor

@etkaar etkaar commented Jan 3, 2021

Closes #553

Adds context menu option "Paste Selected" (Shift+Ctrl+X) to easily copy and paste selected text from terminal into the terminal (similar to PuTTYs select & right click to paste).

Note
I did not touch the translation files in this PL because I think this is exclusively done using Weblate.

Screenshot from 2021-01-03 08 46 30

@etkaar etkaar changed the title Paste selected Adds context menu option "Paste Selected" Jan 3, 2021
@jeremypw jeremypw added the Needs Design Waiting for input from the UX team label Jan 11, 2021
@jeremypw
Copy link
Collaborator

Need input from design team as to whether the value of this function justifies lengthening the menu. (Note, the same functionality can be achieved by pressing <Shift><Ctrl>C + <Shift><Ctrl>V).

@etkaar
Copy link
Contributor Author

etkaar commented Jan 11, 2021

(Note, the same functionality can be achieved by pressing <Shift><Ctrl>C + <Shift><Ctrl>V).

Unfortunately this is not fast enough. However, what I would really prefer would be <Ctrl><RightClick> (or something similar) instead of <Shift><Ctrl>X, but I was not sure if that is possible.

@jeremypw
Copy link
Collaborator

Also <Shift><Ctrl>X might be expected to cut the selected text (although this could only work on an uncompleted command)

@jeremypw jeremypw requested a review from a team June 29, 2021 15:37
@jeremypw jeremypw requested review from a team and removed request for a team September 7, 2021 16:55
jeremypw
jeremypw reviewed Sep 7, 2021
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs input from the design team as to whether the option is needed and what shortcut is appropriate

@felix-andreas
Copy link
Member

Unfortunately this is not fast enough. However, what I would really prefer would be <Ctrl><RightClick> (or something similar) instead of <Shift><Ctrl>X, but I was not sure if that is possible.

There is already middle-click-paste to paste with current selection with the mouse (can be enabled under Settings -> Mouse & Touchpad -> Clicking -> Middle Click Paste). This works in all applications, not only terminal.

There is also the Shift Insert shortcut which pastes the current selection. I think this is implemented by VTE.

@jeremypw
Copy link
Collaborator

jeremypw commented Sep 7, 2021

I can confirm <Shift>Insert works in Terminal to paste the current selection into the commandline.

@etkaar Are you content for this PR to be closed in view of the above comments?

@etkaar
Copy link
Contributor Author

etkaar commented Sep 7, 2021

Yes, the PR can be closed :)

@etkaar etkaar closed this Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw left review comments

Assignees
No one assigned
Labels
Needs Design Waiting for input from the UX team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select > Right click > Copy and Paste
4 participants
@etkaar @jeremypw @felix-andreas @cassidyjames