Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move out from internal packages to allow import #220

Open
WindzCUHK opened this issue Dec 15, 2023 · 0 comments
Open

Move out from internal packages to allow import #220

WindzCUHK opened this issue Dec 15, 2023 · 0 comments

Comments

@WindzCUHK
Copy link
Contributor

Request

Move existing go files out from the internal package. Would it OK for us to make a PR for that?
https://github.com/enix/x509-certificate-exporter/tree/main/internal

Problem

Hi, we are using the x509-certificate-exporter internally and it works great. Thank you very much for your work.
Recently, we have a use case to export more metrics from our application (certificate read frequency, certificate update frequency, etc.). As we want to limit the number of exported ports due to internal policy, we are planning to integrate the x509-certificate-exporter as a go library inside our application to report certificate metrics and the extra metrics using the same exporter port.

However, as the current metric definitions (collector.go) and the related go files are located in the golang's internal package, we cannot import the x509-certificate-exporter in our application and run the exporter server internally. We would like to make PR to move out from the internal package. Please let us know if you have any other suggestions using this project as a library or idea on the new package name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant