Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server level feature gate #18023

Open
9 tasks
siyuanfoundation opened this issue May 17, 2024 · 3 comments
Open
9 tasks

Add server level feature gate #18023

siyuanfoundation opened this issue May 17, 2024 · 3 comments

Comments

@siyuanfoundation
Copy link
Contributor

siyuanfoundation commented May 17, 2024

What would you like to be added?

Add the Kubernetes style feature gate framework into etcd to gate future feature enhancement.
Users would be able to turn features on or off for the single server and query feature enablement in a consistent way.

This issue is for tracking KEP-4578.
Tasks in this KEP include

  • Milestone 1
  • server feature gate interface defined, and code copied from K8s into pkg/.
  • --feature-gates flag added.
  • feature gate added to the server code, and used by a server level experimental feature.
  • feature metrics added.
  • Milestone 2
  • e2e tests added for the feature gate equivalent of the selected experimental feature.
  • robustness test scenarios added for the selected experimental feature(s).
  • documentation to track all feature gates added to [etcd-io/website].
  • Milestone 3
  • create equivalent feature gates for existing --experimental features without removing the old flags.
  • update references to the --experimental feature flags to the new feature gates in the code.

Why is this needed?

To make it easier to add and use new features in etcd.
Please refer to kubernetes/enhancements#4578 for more details.

@siyuanfoundation
Copy link
Contributor Author

while kubernetes/enhancements#4610 is still in review, I think there is no much contention regarding server level feature gate. we can get started on the implementation.
/cc @stackbaek @henrybear327

@henrybear327
Copy link
Contributor

Thanks @siyuanfoundation for the heads up! Happy to contribute to this feature :) Looking forward to it!

@serathius
Copy link
Member

Can we wait for approvals for the KEP so the implementation done by contributors don't need to be updated when the design details are changed frustrating the contributors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants