-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuting to receive "DeprecationWarning: OptionHighlighter is deprecated" as of 1.8.1 #197
Comments
Ah, let me look into this when I get a second. I didn't realize there were two warnings being triggered, but that makes sense that there are. Apologies! As stated in the other issue, our test suite right now is going through a makeover between 1.8 and 1.9. |
I think this should be done. Closing this. |
After installing main with tests/test_script_pickle_statement.py::test_current
/home/james/active/ltools/venv312/lib/python3.12/site-packages/rich_click/rich_click.py:132: DeprecationWarning: OptionHighlighter is deprecated and will be removed in a future version.
from rich_click.rich_help_configuration import OptionHighlighter That's from these lines I think: rich-click/src/rich_click/rich_help_configuration.py Lines 243 to 247 in 2c6e490
|
@jamescooke Sorry. Commented that out for 1.8.3, which was just released. Thanks for your patience and thank you for using rich-click! ❤️ |
This relates to the original issue regarding warnings in #194
Current behaviour
As of version
1.8.1
the warning is still received.Here's a what's received when running Pytest on a test on a click app:
Error appears to come from line 132 which was changed here: https://github.com/ewels/rich-click/pull/196/files#diff-738a2a418c0833585666208ca8a8c9e73b3cd275586e21094d7be7f0fc51dd8fR132
(Running with
1.8.0
, the warning bubbles fromrich_click/rich_click.py:121
, which has changed to line 132 as above)Expected behaviour
No warning is received externally for an internal rich-click warning as mentioned in #194 .
(Personal side note - there is absolutely no rush from me to get this fixed. Just wanted to flag that the warning issue is still present in
1.8.1
🙏🏻 )The text was updated successfully, but these errors were encountered: