Default colors hard to read on Windows terminals

[erezsh]

For example, this is a screenshot on Windows, using "Windows Terminal".

And this one is taken from a regular cmd:

(which is better but still hard to read when it's small)

[ewels]

Yeah, I saw in a comment recently that the colours aren't ideal in light colour themes either. Picking colours that work everywhere is difficult! I want to use colours as much as possible to make content visually distinct (that's kind of the whole point of the package).

Any suggestions for improvements?

[ewels]

NB: Remember that you can overwrite the default styles / colours for any element with rich-click. See the end of the readme. But good defaults is obviously the best solution here.

[erezsh]

I think playing it safe is the best approach for default themes. It's better to risk something being less distinct, than it being hard to read even when your attention is on it.

For dark, I would go with lighter colors (maybe pastel-oriented). I don't know about the light theme, but I guess it needs stronger darker colors.

p.s. note that the first one supports true-color (or close enough), so you can play with shades. The second one is 16 colors, so nothing will make it pretty, but it needs to be cyan or light gray, not blue.

Anyway, just me 2 cents. I know it's hard to get it right for every terminal.

[ewels]

Yup, but what would be playing it safe other than uncoloured text?

Light terminal themes use the same rich-click theme as everything else, so the colours have to work on both light and dark terminal themes. So using lighter paster-colours would be worse for those users.

[erezsh]

Oh, I see the problem now. I assumed there was some way to detect it.

This sounds like a fundamental problem. Maybe rich should implement something like this https://github.com/dalance/termbg

[ewels]

Hmm 🤔 Maybe it does already - I haven't looked for it. Wouldn't be the first time 😅

[erezsh]

Seems that it doesn't right now. But it never hurts to ask - Textualize/rich#1170