Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIA factbook coordinates point to real people's houses (in the Netherlands) - Replace 52 30 N, 5 45 E with 52 24 N, 5 43 E #4

Open
jganseman opened this issue Jan 22, 2021 · 2 comments

Comments

@jganseman
Copy link

As shown in this press article , CIA factbook geographic coordinates can accidentally point to actual homes, leading to problems when people do imprecise location lookups on websites using CIA factbook data in their GIS.

It would be helpful if data read from CIA factbook can be overridden by a default value, only for those few cases where this may be an issue. Geographical coordinates would better point to a nearby river, lake, or that country's parliament building, for example.

Either that, or convincing the CIA to change their factbook. I think doing it here is probably easier :) I am unfortunately not familiar with Ruby so can't contribute a pull request...

@geraldb
Copy link
Member

geraldb commented Jan 22, 2021

You are welcome to provide a list of geo coords that have issues and a list of alternative mappings, for example - no ruby coding required.

@jganseman
Copy link
Author

Thanks for the quick reply!

I'd opt for literal drop-in replacements to override data, such that when the CIA would ever update data on their end, the webscraper automatically reverts back to the CIA version. Probably also the easiest to implement, with just a search-and-replace in the right spot.

For the moment I'm only aware of the Netherlands causing actual trouble. A file `with override definitions could have this content for example:

overrides.txt

# from html source : https://www.cia.gov/the-world-factbook/field/geographic-coordinates 
"<p>52 30 N, 5 45 E</p>" --> "<p>52 24 N, 5 43 E</p>"

@geraldb geraldb changed the title CIA factbook coordinates point to real people's houses CIA factbook coordinates point to real people's houses (in the Netherlands) - Replace 52 30 N, 5 45 E with 52 24 N, 5 43 E Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants