Unable to use ff4j web console in quarkus application: Caused by: java.lang.ClassNotFoundException: org.acme.MyFF4jProvider

[franden]

If I try to use ff4j web console in a quarkus application, I get following Exception on startup of the FF4jDispatcherServlet that the class of my FF4jProvider is not known:

Caused by: java.lang.ClassNotFoundException: org.acme.MyFF4jProvider
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
        at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:428)
        at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:378)
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:315)
        at org.ff4j.web.FF4jServlet.initializeFF4J(FF4jServlet.java:152)
        ... 29 more

The reason is this line:

ff4j/ff4j-web/src/main/java/org/ff4j/web/FF4jServlet.java

Line 152 in f3c07b4

Class<?> c = Class.forName(className);

As described here: "Class.forName() without a CL is often problematic."

Please change this line to use the current classlaoder: Class<?> c = Thread.currentThread().getContextClassLoader().loadClass(className);

[clun]

You are right will work on it over the week-end would be great to have a quarkus sample in the pool

[franden]

Similar Issue happens if custom flipping strategy is used. In this case the custom class can not be loaded (ClassNotFoundException):

ff4j/ff4j-core/src/main/java/org/ff4j/utils/MappingUtil.java

Line 183 in a31cb8c

Class<FlippingStrategy> clazz = (Class<FlippingStrategy>) (classLoader == null ? Class.forName(className) : classLoader.loadClass(className));

it could be changed to:
Class<FlippingStrategy> clazz = (Class<FlippingStrategy>) (classLoader == null ? Thread.currentThread().getContextClassLoader().loadClass(className) : classLoader.loadClass(className));

Currently I am using: MappingUtil.setClassLoader(Thread.currentThread().getContextClassLoader()); as workaround

[franden]

I guess the similar issue will happen everywhere where Class.forName(className) is used to load custom code from
e.g:

ff4j/ff4j-core/src/main/java/org/ff4j/property/util/PropertyFactory.java

Line 163 in a31cb8c

Constructor<?> constr = Class.forName(pType).getConstructor(String.class, String.class);