Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] Jedis 4 compatibility #722

Open
vandykej17 opened this issue Nov 2, 2023 · 0 comments
Open

[New Feature] Jedis 4 compatibility #722

vandykej17 opened this issue Nov 2, 2023 · 0 comments
Assignees

Comments

@vandykej17
Copy link

Is your feature request related to a problem? Please describe.
When using ff4j-store-redis with spring boot 3, we have to downgrade the version of jedis due to incompatibilities with jedis 4. The issue is FF4J is using Jedis.expire(String, int), but since Jedis 3 that method has been deprecated and in Jedis 4 it was removed.

The error I get is very clear.

Caused by: java.lang.NoSuchMethodError: 'java.lang.Long redis.clients.jedis.Jedis.expire(java.lang.String, int)'
	at org.ff4j.cache.FF4jCacheManagerRedis.putFeature(FF4jCacheManagerRedis.java:199)
	at org.ff4j.cache.FF4jCacheProxy.create(FF4jCacheProxy.java:154)

Describe the solution you'd like
I would like ff4j-store-redis to change this method to returning a long so it is compatible with Jedis 4. Obviously would be a good idea to change the setter and the property as well.

Describe alternatives you've considered
Locking my applications to jedis 3.X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants