BUGFIX - gold+iron smelters sound problem

[p1plp1]

DataSourceDOS::get_sound(size_t index) { needs to be bugfixed for sound with if (index == 62),
when this resource is played it bubles only once and then high tone beeeep noise only ... any idea how to load this resource and cut only real data and play it correctly?

[sternenzaehler]

I will try to look into it.

[tlongstretch]

I had tried applying p1plp1's personal fix in my fork but it didn't seem to work so I reverted it.

[p1plp1]

that was not fix :) that was only problem finding, for iron smelter sound with index 62 is there still problem, i tried to cut off and force sound lenght for index 62 with some constant value but without success, any progress anyone?

[tlongstretch]

My work-around is to play the Amiga sound instead. This could take a ton of time to solve the root cause, it doesn't seem worth the effort to me

[p1plp1]

hello tlongstretch can i ask u for actual bugfixed whole compiled +sources packed into zip? i have difficulties to compile and run your version ... :( actually i cant get it working and play amiga music, when i use amiga data files also color palette is bad

[tlongstretch]

Of Forkserf or Freeserf? On Forkserf "Releases" area I have pre-compiled binaries for linux and windows, though I've only tested the legacy glibc versions personally. I can probably compile Freeserf also if you're having issues compiling it, though I thought it was already published here on Freeserf project.

https://github.com/forkserf/forkserf/releases

Freeserf has always had compiled binaries herE: https://github.com/freeserf/freeserf/releases/tag/v0.3

[tlongstretch]

When you say Amiga color palette is bad, what are you expecting it to look like? I had always assumed this is what it originally looked like as I never saw the Amiga version. Now, looking at screenshots if I google for "Settlers Amiga" it looks much like the DOS version. I think you are correct that the terrain is corrupted, but I'm not sure if there's anything that can be done to fix it. It looks same to me in Freeserf or Forkserf

[tlongstretch]

Regarding the DOS boils sound, I tried experimenting with editing it chunk by chunk as it loads and no success.

[jacefuse]

Unless I am mistaken, the Amiga version of Settlers was using Extra Half Bright. The reason the colors may come out wrong is probably because the bitmap uses 64 colors but only 32 are defined in the pallet. The upper 32 colors are a copy of the lower 32 colors but only half as bright. If there are colors defined in the upper 32 colors of the pallet, they may not be the correct colors.

…

--- END OF MESSAGE! --- From: tlongstretch Sent: Wednesday, January 4, 2023 9:15 PM To: freeserf/freeserf Cc: Subscribed Subject: Re: [freeserf/freeserf] BUGFIX - gold+iron smelters sound problem (#478) When you say Amiga color palette is bad, what are you expecting it to look like? I had always assumed this is what it originally looked like as I never saw the Amiga version. Now, looking at screenshots if I google for "Settlers Amiga" it looks much like the DOS version. I think you are correct that the terrain is corrupted, but I'm not sure if there's anything that can be done to fix it. It looks same to me in Freeserf or Forkserf — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[p1plp1]

yes, looks like that mess on that picture, pallete must be fixed prior of displaying any sprites etc.
i have two ideas:
-maybe saving pc pallete and trying to apply it with amiga files can solve this
-or try to redefine upper 32 collors with some constant (compare with original pc pallete) and only redefine
maybe it is pallete_color(index+32)=pallete_color(index+32)*4 for example, dunno "maybe some inspiration for some formula is based in default 256color pallette:

[tlongstretch]

you might be correct about the fix. Is there a significant different in the (correct) Amiga graphics versus DOS? The non-terrain sprites look extremely similar, and I nearly all cases I think the DOS ones look better. The only ones where Amiga looks arguably better are the Castle, Stock, and Garrison sprites, where Amiga has a brown roof while DOS has red.

[GraionDilach]

The star overlay on the ingame bottom bar's buttons when they are active is only animated in Amiga AFAIK.

[tlongstretch]

You are right, that spinning star does look slick. I just watched some youtube amiga settlers gameplay. I don't see anything else that looks significant, though. I think implementing the amiga spinning star and otherwise using DOS graphics is the way to go!

[tlongstretch]

it seems Freeserf does not implement the spinning star even if using Amiga graphics, unfortunately

[p1plp1]

about boiling sound - i have just unconfirmed idea that problem can be in sound extraction algorythm, maybe i try to expand data and save it as playable wav sound and test it in audio player, if problem happends just during loading sound from file due to wrong algorythm.

[p1plp1]

about castle, storage - hmmm that brown roof + rock wall looks better but if u look at road at front of the storage it looks dirty in amiga version, that red / brown roof is maybe rooot of that pallete problem --> what about shifting brown to be more red? maybe it fixes whole game and that terrain + desert textures too ...

[p1plp1]

now im sure i have problems with mingw64 compiler and threads on Windows x64 ... dunno exactly why but i get SDL_CreateMutex errror hm, i updated mingw during time ...

[tlongstretch]

maybe try VSCode? That is what I am using on linux, and I was using VisualStudio Community Edition when I was developing on Windows

[tlongstretch]

I got the amiga spinning star working as a prototype. I had to extract the spinning star frame by frame from a youtube video, if anybody knows how to extract it from the amiga data files that would be better, but this still looks pretty good

amiga_spinning_star_example.mp4

[zdechlak]

https://thecompany.pl/gra/Settlers%7C+The

here you can play settlers via amiga emulator