Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug - knights won't automatically spawn if any Knight0 already in Inventory #503

Open
tlongstretch opened this issue Dec 29, 2021 · 1 comment

Comments

@tlongstretch
Copy link

inside Inventory.cc's Inventory::specialize_serf
...
if (serfs[type] != 0) {
return false;
}
...

fix (applied in my fork)
// must exclude Knights from this check!
if (serfs[type] != 0 && !(type >= Serf::TypeKnight0 && type <= Serf::TypeKnight4)) {
return false;
}

@tlongstretch
Copy link
Author

I assume this was intended to prevent creation of new specialist (non-knight) when an existing one could be sent out, but should not be applied to knights

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant