Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think and discuss two PRs related to NotifyIdle #166

Open
fzyzcjy opened this issue Nov 5, 2022 · 4 comments
Open

Think and discuss two PRs related to NotifyIdle #166

fzyzcjy opened this issue Nov 5, 2022 · 4 comments

Comments

@fzyzcjy
Copy link
Owner

fzyzcjy commented Nov 5, 2022

flutter/engine#36797

We don't want to expose this kind of internal of the VM to users.
Perhaps it would be more appropriate to expose a different API around whether an animation is occurring currently, although I think @iskakaushik has already done some work on that.

flutter/engine#36834

Same problems as the other NotifyIdle PR - these are details we don't want to expose to users. NotifyIdle might not do anything, or it might do a lot more than the user expects. In all honesty, it would be nice to get rid of it entirely since it is hard to reason about and seems to come out wrong very frequently. If users can change this arbitrarily it will make it much harder to reason about what's going on in an application.
Closing this to remove from review queues. There is definitely work to do around NotifyIdle, but I think we'll need some cooperation from the dart VM team on it.

@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Nov 5, 2022

replied on github. maybe later discuss on discord or ping?

@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Nov 5, 2022

(leave this issue open, so not forget I am waiting for reply)

@stale
Copy link

stale bot commented Jan 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 4, 2023
@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Jan 4, 2023

bump

@stale stale bot removed the wontfix This will not be worked on label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant