Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgpu does not map all OutOfMemory errors to wgpu::Error::OutOfMemory #5718

Open
sagudev opened this issue May 19, 2024 · 2 comments
Open

wgpu does not map all OutOfMemory errors to wgpu::Error::OutOfMemory #5718

sagudev opened this issue May 19, 2024 · 2 comments
Labels
area: validation Issues related to validation, diagnostics, and error handling help wanted Contributions encouraged type: bug Something isn't working

Comments

@sagudev
Copy link
Contributor

sagudev commented May 19, 2024

Here

if let Some(wgc::device::DeviceError::OutOfMemory) =
only wgc::device::DeviceError::OutOfMemory error is mapped to wgpu::Error::OutOfMemory, while https://docs.rs/wgpu/latest/wgpu/?search=OutOfMemory lists more way OutOfMemory variants.

@sagudev sagudev changed the title Wgpu only detect wgpu does not map all OutOfMemory errors to wgpu::Error::OutOfMemory May 19, 2024
@Wumpf Wumpf added type: bug Something isn't working help wanted Contributions encouraged area: validation Issues related to validation, diagnostics, and error handling labels May 19, 2024
@ErichDonGubler
Copy link
Member

The problem statement here is pretty vague. It's unclear what action items should result from this. Is there a concrete test case or application in which you've found this results in issues? I don't doubt there are issues, but we should try to make this as easy for contributors to act upon as we can.

@sagudev
Copy link
Contributor Author

sagudev commented Jun 10, 2024

The problem statement here is pretty vague. It's unclear what action items should result from this. Is there a concrete test case or application in which you've found this results in issues? I don't doubt there are issues, but we should try to make this as easy for contributors to act upon as we can.

I noticed this in when using similar error mapping code in servo, but it didn't catch all OOM errors. IIRC create_texture returned such error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: validation Issues related to validation, diagnostics, and error handling help wanted Contributions encouraged type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants