-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot add project when filetree contains a socket #3614
Comments
Thanks for reporting! It looks like you are on Windows and aren't using the latest version, 0.11.4 at the moment. There the issue you are describing should be fixed. Could you try to update and try again? Thank you. |
I'm on Linux. Maybe I wasn't using 0.11.4 at the time, but now I am. The log now shows:
|
Thanks you! That's strange - |
I actually can't reproduce this on MacOS. Not only does our client ignore it, but even the Git CLI ignores it entirely, even without a EDIT: This looks like a symlink, that's a clue. Let me check. I still can't reproduce on Mac for some reason; I tried
This might be linux specific. I'm not sure why we'd be trying to open it, though, given that it's gitignored. That's really strange and doesn't seem like it'd be platform-specific. A clue that this is a symlinked + closed (server is dead) socket is that the realpath gets resolved to We do have a bug, however, that GItButler will show a symlinked/hardlinked socket in the file tree erroneously, but it seems to be unaffected by commits (as it should be). Git CLI at least follows the symlink and tries to However that doesn't address the fact I still can't reproduce on Mac 😓 I'll have to try this on Linux when I get a chance. |
I tried to import my project, in the project directory there is a socket file (which is in the
.gitignore
) which is used to run the project locally. Having this socket in existence makes project import fail:You can clone the project from https://gitlab.com/gitlab-org/gitlab-development-kit/, but you need to run the whole SDK to run into this, so I've created reproduction steps:
git init my-project cd my-project nc -lU my.socket
Try to import that, and you'll get "Something went wrong".
While I was testing this I noticed import seems to hang when you have a named pipe in your repo, created with
mkfifi my.pipe
.The text was updated successfully, but these errors were encountered: