Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect report about running checks #3684

Open
Fryuni opened this issue May 4, 2024 · 2 comments
Open

Incorrect report about running checks #3684

Fryuni opened this issue May 4, 2024 · 2 comments
Labels
bug Something isn't working integration Integration with Git-forges and tooling UX/UI Focusing on user satisfaction, usability, and overall experience

Comments

@Fryuni
Copy link

Fryuni commented May 4, 2024

I have tests still running, but the ones that have been completed have all passed. Until the last check completes or one of them fails, it shows both "checks passed" (implying that everything is fine) and a warning stating that checks failed.

image

@Fryuni
Copy link
Author

Fryuni commented May 4, 2024

Intel Mac, latest version

Nothing blocking, it is only while the tests are still running. Once the tests are completed, be it failing or succeeding, it reports correctly.

@Qix- Qix- added bug Something isn't working UX/UI Focusing on user satisfaction, usability, and overall experience integration Integration with Git-forges and tooling labels May 6, 2024
@kochalex
Copy link

I'm getting this warning on a repo has required reviewers on a PR that 1. has all tests passing but 2. was not yet approved by a reviewer.

After the review, the warning went away.

So maybe the warnings should be specific to each state or more general that merging is blocked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integration Integration with Git-forges and tooling UX/UI Focusing on user satisfaction, usability, and overall experience
Projects
None yet
Development

No branches or pull requests

3 participants