Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Git repo on Windows opens up the terminal window #3769

Closed
sschuberth opened this issue May 16, 2024 · 10 comments · Fixed by #3800
Closed

Adding a Git repo on Windows opens up the terminal window #3769

sschuberth opened this issue May 16, 2024 · 10 comments · Fixed by #3800
Labels
bug Something isn't working feedback requested Feedback was requested to help resolve the issue os:windows The Windows platform

Comments

@sschuberth
Copy link

I was starting GitButler on Windows for the first time. When asked to add a repository, I navigated to one and selected the folder. Immediately afterwards, the Windows terminal application popped up, with no indication whatsoever why that happened.

Any idea why that happens, and how it can be avoided?

@Byron Byron added bug Something isn't working os:windows The Windows platform labels May 16, 2024
@Byron
Copy link
Collaborator

Byron commented May 16, 2024

Thanks for reporting! I assume it's version 0.11.7 that you are using?
It's the first time (at least) I hear about this, but if it happens each time a repository is added, it should be easily reproducible .

@sschuberth
Copy link
Author

I assume it's version 0.11.7 that you are using?

Yes. Sorry for omitting that information initially.

if it happens each time a repository is added, it should be easily reproducible .

I just verified that it also happens (again) when adding another repo via "Add new project" from the combobar in the upper left of an existing project.

@DrBarnabus
Copy link
Contributor

I started getting this with the latest nightly, it's not just adding a new repo it's basically any action for example:

  • Edit a file and save
  • Click to refresh commits on Trunk
  • Click to update workspace

Seems basically everything that causes a git operation opens the terminal for a split second.

@sschuberth
Copy link
Author

opens the terminal for a split second.

In my case though, actually the terminal window stays open.

@Byron
Copy link
Collaborator

Byron commented May 19, 2024

I have a feeling that this is due to git now being invoked for these operations, but with the CREATE_NO_WINDOW flag missing.

Can it be that you are using a signing key or have commit signing enabled in any way? And if so, if you turn it off, does the Cmd-popup go away?

Edit: With a plain installation on Windows 11 I didn't reproduce the Cmd window popup, but also know that commit signing is disabled and the added project was never touched by GB either.

@Byron Byron added the feedback requested Feedback was requested to help resolve the issue label May 19, 2024
@sschuberth
Copy link
Author

sschuberth commented May 19, 2024

Can it be that you are using a signing key or have commit signing enabled in any way?

I don't have cryptographic singing of commits enabled. In some of my repos I use a commit message template to add a Signed-off-by footer, but not in the repo I use for evaluating GitButler.

@sschuberth
Copy link
Author

Is there a way to log which exact git command line GitButler tries to run?

@DS-DanielW
Copy link

I have a feeling that this is due to git now being invoked for these operations, but with the CREATE_NO_WINDOW flag missing.

Can it be that you are using a signing key or have commit signing enabled in any way? And if so, if you turn it off, does the Cmd-popup go away?

Edit: With a plain installation on Windows 11 I didn't reproduce the Cmd window popup, but also know that commit signing is disabled and the added project was never touched by GB either.

Can confirm in my case at least this seems to be the issue, disabling commit signing stopped the windows appearing.

@Byron
Copy link
Collaborator

Byron commented May 21, 2024

Thanks everyone for your help! A fix is brewing in #3800 now.

@Byron
Copy link
Collaborator

Byron commented May 21, 2024

Is there a way to log which exact git command line GitButler tries to run?

Currently command invocations aren't specifically logged, but it's definitely something to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feedback requested Feedback was requested to help resolve the issue os:windows The Windows platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants