Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink package API #61

Open
gkjohnson opened this issue Aug 4, 2018 · 1 comment
Open

Rethink package API #61

gkjohnson opened this issue Aug 4, 2018 · 1 comment
Labels

Comments

@gkjohnson
Copy link
Owner

Providing a string to replace package:// is technically incorrect by ROS standards. An option has been added to to provide a package map which could replace the currently functionality entirely. The URDF file should also not be loaded relative to the package path, either.

@gkjohnson gkjohnson added this to the v0.4.0 milestone Aug 18, 2018
@gkjohnson
Copy link
Owner Author

The urdf file is no longer loaded relative the provided package path.

The remaining confusing bit is that when just a string is provided both loaders will check if the provided path ends with the package name, in which case it will dedupe the directory. This logic may be removed so it doesn't have to be explained in documentation.

@gkjohnson gkjohnson removed this from the v0.4.0 milestone Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant